Last modified: 2013-07-25 10:31:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39422, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37422 - Lat/lon should be NULL when empty
Lat/lon should be NULL when empty
Status: REOPENED
Product: Wiki Loves Monuments
Classification: Unclassified
Database (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-09 15:16 UTC by Maarten Dammers
Modified: 2013-07-25 10:31 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maarten Dammers 2012-06-09 15:16:22 UTC
At the moment it's 0.
Comment 1 Platonides 2012-06-23 12:55:18 UTC
Heh, you were the first one adding tables with those fields as NOT NULL DEFAULT '0'.

I agree. Most other fields are NOT NULL with not-set stored as an empty string, but lat and long are doubles.
Comment 2 Maarten Dammers 2012-07-11 20:16:55 UTC
r1=736&r2=737">https://fisheye.toolserver.org/browse/erfgoed/erfgoedbot/sql/fill_table_monuments_all.sql?r1=736&r2=737 isn't very nice. Should probably fix it on the python import bot. If lat=0 and lon=0 insert NULL
Comment 3 Maarten Dammers 2012-12-01 21:49:05 UTC
Still need to fix some leftovers:

mysql> SELECT COUNT(*) FROM monuments_all WHERE lat='' OR lon='' OR lat=0 OR lon=0;
+----------+
| COUNT(*) |
+----------+
|      186 |
+----------+
1 row in set (12.71 sec)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links