Last modified: 2012-08-14 17:40:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39449, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37449 - License texts missing when using campaigns in UploadWizard
License texts missing when using campaigns in UploadWizard
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks: 37144
  Show dependency treegraph
 
Reported: 2012-06-10 11:06 UTC by Maarten Dammers
Modified: 2012-08-14 17:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maarten Dammers 2012-06-10 11:06:21 UTC
When I try to upload a photo using one of the campaigns at Commons (for example https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wlm-nl) I get missing system messages at the "release rights" step:

[mwe-upwiz-source-ownwork-assert-cc-by-sa-3.0-nl]
[mwe-upwiz-source-ownwork-cc-by-sa-3.0-nl-explain]

When I look at the normal UploadWizard I see that a lot of license options are missing so that might be related.

These local licenses worked in September 2011 for Wiki Loves Monuments so someone must have broken it. The option to select the license is available at https://commons.wikimedia.org/wiki/Special:UploadCampaign/wlm-nl
Comment 1 Mark Holmquist 2012-06-11 17:12:49 UTC
So, it looks like the default cc-by-sa-3.0 is a defined i18n message, but cc-by-sa-3.0-nl is not; and for some reason that license is defined in the default configuration anyway, as a valid license choice. That really doesn't make a lot of sense, but we work with what we have.

I'll add in license messages for each of the localized cc-by-sa licenses, but I can't guarantee that it's a full list. Also, they're in English, so it may not be terribly helpful until TranslateWiki hops in to help.

Patch here: https://gerrit.wikimedia.org/r/10954

Also, note that the translated deed pages will probably get included at some point in the near future per bug 33330.
Comment 2 Pikne 2012-06-30 07:05:05 UTC
They are now translatable, but half of these 20 new messages are identical to earlier message mwe-upwiz-source-ownwork-cc-by-sa-3.0-explain. Unless this is intentional, isn't it neater to just make the interface use that one message instead of ...nl-explain, ...no-explain, -de-explain etc?
Comment 3 Maarten Dammers 2012-07-28 11:53:02 UTC
Bumping to high because this is causing issues on the producation UploadWizard on Commons.
Comment 4 Mark Holmquist 2012-07-30 15:44:16 UTC
Maarten: Did the above patch not fix it? I realize it was an imperfect patch (see #2) but it should have done the trick.

Maybe we haven't deployed a new UW version since mid-June? If so, wow.
Comment 5 Maarten Dammers 2012-07-30 19:01:30 UTC
I'm pretty sure this fixed it, but if it's not deployed we still have the problem :-(
Comment 6 Maarten Dammers 2012-08-05 14:05:08 UTC
I think Reedy deployed it, but I still see the same issue
Comment 7 Mark Holmquist 2012-08-06 17:17:09 UTC
You're right!

https://gerrit.wikimedia.org/r/17818 should fix the problem. If someone could sanity-check my work that would be great.
Comment 8 Mark Holmquist 2012-08-14 16:18:22 UTC
Closing because the above patch was merged (apparently). If problem persists please reopen.
Comment 9 Maarten Dammers 2012-08-14 16:31:41 UTC
See https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wlm-nl . It's not working.
Comment 10 Maarten Dammers 2012-08-14 16:47:05 UTC
Added shell, latest version needs to be pushed to Commons to confirm this in fact is fixed.
Comment 11 Mark Holmquist 2012-08-14 16:48:43 UTC
This is no longer a UW bug, but feel free to bounce it back if you find problems.
Comment 12 Mark Holmquist 2012-08-14 16:55:34 UTC
Sorry, accidentally closed.
Comment 13 Mark Holmquist 2012-08-14 17:40:53 UTC
https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wlm-nl&debug=true

Confirmed that it works, closing *finally*.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links