Last modified: 2013-03-07 17:07:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39480, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37480 - API should return error if External Store master not available - Pages not created on Commons
API should return error if External Store master not available - Pages not cr...
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-12 05:57 UTC by Lupo
Modified: 2013-03-07 17:07 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lupo 2012-06-12 05:57:40 UTC
Several reports at the Commons about non-existing pages that should exist. Examples at the time of writing:

https://commons.wikimedia.org/wiki/Commons:Deletion_requests/Files_in_Category:De_Gesammelte_Abhandlungen_%28Hertz_W%29

Page should have been created at 2012-06-12, 00:01 UTC according to https://commons.wikimedia.org/w/index.php?title=Commons:Deletion_requests/2012/06/12&action=history

Probably the user used https://commons.wikimedia.org/wiki/MediaWiki:Gadget-AjaxQuickDelete.js to create this deletion nomination.

Then there's a whole series of uploaded files: https://commons.wikimedia.org/w/index.php?title=Commons:Administrators%27_noticeboard&oldid=72480417#Flickr2Commons_upload_bug

Presumably, Magnus's tool also uses the API to create pages. These files were uploaded around 2012-06-11 23:51 UTC.

In all cases, the page reports "The database did not find the text of a page that it should have found..."

Can this be related to the DB master switch around that time?

https://wikitech.wikimedia.org/view/Server_admin_log#June_12
Comment 1 Rainer Rillke @commons.wikimedia 2012-06-12 16:43:44 UTC
+1 (file uploaded, no description page created)
https://commons.wikimedia.org/wiki/File:DEU_Osterath_COA.svg
Comment 2 Asher Feldman 2012-06-13 20:55:45 UTC
This was a result of the External Store master crashing.  Between roughly 2012-06-11 23:48 (es1 crashing) and 23:52 (promoting es1 to master), it was not possible to save revision text, requisite for page creation.
Comment 3 Jarry1250 2012-06-13 20:59:23 UTC
Presumably we should really block the upload if we can't write the page?
Comment 4 Sam Reed (reedy) 2012-08-12 21:42:48 UTC
(In reply to comment #3)
> Presumably we should really block the upload if we can't write the page?

One would hope it would be wrapped in a transaction, and rollback on failure and go LOLNO
Comment 5 Bryan Tong Minh 2012-09-23 21:00:03 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Presumably we should really block the upload if we can't write the page?
> 
> One would hope it would be wrapped in a transaction, and rollback on failure
> and go LOLNO

I remember fixing a similar bug before, but that was when writing to the page table failed. Apparently failure to store the text has a different failure path.
Comment 6 Bryan Tong Minh 2012-09-23 21:06:13 UTC
Moving back to General/Unknown, as I misread the original bug report; also non-file pages are affected.

As for the uploading, this is really bug 15430 in another incarnation.
Comment 7 Andre Klapper 2012-12-31 14:33:31 UTC
(In reply to comment #2)
> This was a result of the External Store master crashing.  Between roughly
> 2012-06-11 23:48 (es1 crashing) and 23:52 (promoting es1 to master), it was
> not possible to save revision text, requisite for page creation.


The goal of this bug report is not clear to me. Make sure this does not happen again next time it crashes, by blocking uploads somehow?
Comment 8 Rainer Rillke @commons.wikimedia 2013-01-01 13:38:22 UTC
(In reply to comment #7)
>The goal of this bug report is not clear to me. Make sure this does not happen
>again next time it crashes, by blocking uploads somehow?

At least the API should return an error. As for the deletion requests, the API must have responded something different than "error". Otherwise the non-existant page wouldn't have been listed to the 2012/06/12 page.

And I agree that uploads (at least moving from stash to target) should be blocked when the text revision can't be created.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links