Last modified: 2014-07-16 08:19:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39485, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37485 - Convert ext.wikiEditor.tests.toolbar to QUnit


Summary:	Convert ext.wikiEditor.tests.toolbar to QUnit

Status:	NEW

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikiEditor (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy, need-unittest

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-06-12 08:15 UTC by Michael M.
Modified:	2014-07-16 08:19 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2012-06-12 08:15:05 UTC

The use of this testsuit is somewhat limited, since there is no way to execute it automatically (you even have to load this module by hand!)
Convert it to QUnit test to run them automatically, and expand the tests to cover things like bug 37484.

Comment 1 Alexander Jones 2014-07-15 14:03:53 UTC

I've been working on this bug. I'll try to post something to Gerrit this week. As it stands, there is one assertion that fails. It looks like there's a bug preventing the removal of select tools.

Comment 2 Michael M. 2014-07-16 08:16:31 UTC

According to the code [1] removeFromToolbar is not designed to be able to remove select tools (and probably never was). Changing line 161 to

target = target + ' [rel="' + data.tool + '"].tool';

might fix this.

[1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor/f5fcd50ce421b55a3d0a15f6c7d7707518a7284a/modules%2Fjquery.wikiEditor.toolbar.js#L148

Comment 3 Alexander Jones 2014-07-16 08:19:39 UTC

Should I fix that in the same commit?

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links