Last modified: 2012-11-28 13:51:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39502, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37502 - ItemHandler::getParserOutput() must not touch OutputPage
ItemHandler::getParserOutput() must not touch OutputPage
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on: 37501
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-12 13:49 UTC by Daniel Kinzler
Modified: 2012-11-28 13:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-06-12 13:49:03 UTC 
ItemHandler::getParserOutput() currently uses ItemView::render(), which in turn manipulates the OutputPage. 

ItemHandler::getParserOutput() is called in various contexts, and must not have side effects on the global state. We need separate functions for constructing the ParserOutput and for actually showing an item (using a ParserOutput object).
Comment 1 Daniel Kinzler 2012-06-19 11:43:25 UTC 
fixed by https://gerrit.wikimedia.org/r/11293
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links