Last modified: 2014-07-30 18:44:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39585, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37585 - Update GeSHi library when a new version is available
Update GeSHi library when a new version is available
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
https://sourceforge.net/tracker/?func...
: upstream
Depends on: 39643
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-14 09:39 UTC by Dereckson
Modified: 2014-07-30 18:44 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dereckson 2012-06-14 09:39:11 UTC
+++ This bug was initially created as a clone of Bug #37044 +++

Initial bug :
    [mediawiki/extensions/SyntaxHighlight_GeSHi.git] / geshi / geshi / html5.php
    End of line 61 is "." and should be "," instead.

To solve the previously described bug, the current GeSHi code in the extension doesn't match the upstream version anymore.

As soon a new GeSHi release is available, this issue should be solved to maximize compatibility, updating our GeSHi codebase by the upstream one.

Warning: the GeSHi branch we use is the 1.0.X (-> 1.0.x releases), not the trunk (-> 1.1.x releases) one.
Comment 1 Dereckson 2012-06-14 09:53:44 UTC
Adding 'upstream' keyword.

I opened a new release request on the upstream bug tracker:
https://sourceforge.net/tracker/?func=detail&aid=3535146&group_id=114997&atid=670231
Comment 2 Sam Reed (reedy) 2012-06-14 20:52:03 UTC
(In reply to comment #0)
> Warning: the GeSHi branch we use is the 1.0.X (-> 1.0.x releases), not the
> trunk (-> 1.1.x releases) one.

Active development doesn't seem to be happening on that branch, so I'm not quite sure what's going on. It's quite weird their isn't consistent development.

http://geshi.svn.sourceforge.net/viewvc/geshi/trunk/geshi-src/?view=log
http://geshi.svn.sourceforge.net/viewvc/geshi/trunk/geshi-1.0.X/?view=log



I actually have commit rights on the GeSHi SVN repository. So I can actually tag a new release for this, I just don't think I've got the rights to upload tarballs etc
Comment 3 JuanPi 2012-06-27 11:51:43 UTC
Hi,

The lastmodification was done to 
http://geshi.svn.sourceforge.net/viewvc/geshi/trunk/geshi-1.0.X/

Which is related to a new language file we created. GNU Octave language is still not supported by Wikipedia (but the GeSHi website does), so I guess there is a language file synchro issue.

Can this be fixed?

Thanks
Comment 4 Sam Reed (reedy) 2012-06-27 11:52:52 UTC
(In reply to comment #3)
> Hi,
> 
> The lastmodification was done to 
> http://geshi.svn.sourceforge.net/viewvc/geshi/trunk/geshi-1.0.X/
> 
> Which is related to a new language file we created. GNU Octave language is
> still not supported by Wikipedia (but the GeSHi website does), so I guess there
> is a language file synchro issue.
> 
> Can this be fixed?
> 
> Thanks

We use tagged releases for ease, rather than copying out trunk
Comment 5 JuanPi 2012-06-27 11:55:37 UTC
Thanks for the answer Sam,

I will talk to Ben (geshi-dev) to see if he can relaese, or at least to know when he plans to do that.
Comment 6 Dereckson 2012-06-27 20:38:46 UTC
Ben answered, thank you Juan.

"Problem has been on radar for some months now. I'm currently missing the
spare time for it right now, but plans for upcoming releases exist."
Comment 7 Dereckson 2012-08-30 21:52:42 UTC
Blocked by our '0' fix.
Comment 8 Sam Reed (reedy) 2014-07-30 18:44:04 UTC
I've done an import of master at 4895d6d588 in https://gerrit.wikimedia.org/r/#/c/150622/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links