Last modified: 2012-12-13 11:17:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39634, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37634 - Display the label of an item in the Recent Changes
Display the label of an item in the Recent Changes
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest enhancement (vote)
: ---
Assigned To: Wikidata bugs
storypoints: 1
:
Depends on: 37312
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-15 17:06 UTC by denny vrandecic
Modified: 2012-12-13 11:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description denny vrandecic 2012-06-15 17:06:12 UTC

    
Comment 1 denny vrandecic 2012-06-15 17:07:30 UTC
Recent changes displays the Title of the page, which, in case of an item, is a numeric identifier. The recent changes has to include additionally the label of the item for the selected language in order to be minimally useful.
Comment 2 Brion Vibber 2012-06-15 19:30:47 UTC
I think you guys will want a fairly general 'get human-readable title' method on Title; this could look up usage of DISPLAYTITLE and other similar things in general, and could hook into your label lookups here.
Comment 3 Nikola Smolenski 2012-06-18 06:08:10 UTC
Yes, if possible, a more general method would be better. See also #37312.
Comment 4 Daniel Kinzler 2012-06-18 09:07:09 UTC
I don't (In reply to comment #2)
> I think you guys will want a fairly general 'get human-readable title' method
> on Title; this could look up usage of DISPLAYTITLE and other similar things in
> general, and could hook into your label lookups here.

Would be nice, but I don't see a way to guarantee that this can always be done without loading the actual content. That would be expensive, and thus not a good thing to do in potentially long listings like RecentChanges. Also, in that case, it would make more sense to put the method into WikiPage, not Title.

Hm, maybe the human readable title could be stored in pageprops... dies DISPLAYTITLE already go there?
Comment 5 Daniel Kinzler 2012-06-18 09:08:08 UTC
(In reply to comment #2)

Oh, I forget: for Wikidata, the human readable title depends on the user language. Could still be done with pageprops, but has the potential of swamping that table.
Comment 6 jeblad 2012-06-18 14:11:24 UTC
Seems like there are different places to hook in for different types of special pages.

'OldChangesListRecentChangesLine' works for RecentChanges, but needs a heavy lookup. It is already other heavy actions there. Not sure if a little more really makes any big difference. Because several accesses this page at the same time I would propose to simply use the memcached for caching the title-language-label-lookup.

'LogLine' works for several logging pages. It also have a load issue, but is used much more seldom than the recent changes. Not sure if there is anything to gain on caching values..

'ShowSearchHitTitle' should be used too.

'Special::NewPagesFilter' seems to be odd, not sure if this is covered by any of the other hooks.
Comment 7 Daniel Kinzler 2012-06-18 15:20:50 UTC
(In reply to comment #6)
> Seems like there are different places to hook in for different types of special
> pages.

I still think we should just use LinkStart to hook into the Linker. We may need a global state switch of some sort to disable this when parsing wikitext...
Comment 8 Anja Jentzsch 2012-11-29 12:38:03 UTC
Verified in Wikidata demo time for sprint 8

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links