Last modified: 2012-08-15 12:45:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39638, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37638 - Replace LogPage::logName
Replace LogPage::logName
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Logging (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Dereckson
http://svn.wikimedia.org/doc/classLog...
: testme
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-15 21:10 UTC by Platonides
Modified: 2012-08-15 12:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2012-06-15 21:10:18 UTC 
Since the LogPage refactoring months ago, there are still many usages of the now deprecated LogPage::logName which need to be updated:

Problems in mediawiki/core/includes/Article.php:
 Non deprecated function delete calls deprecated function LogPage::logName in line 1345
 Non deprecated function confirmDelete calls deprecated function LogPage::logName in line 1513
 Non deprecated function doDelete calls deprecated function LogPage::logName in line 1543
Problems in mediawiki/core/includes/ChangesList.php:
 Non deprecated function recentChangesBlockLine calls deprecated function LogPage::logName in line 1148
Problems in mediawiki/core/includes/ProtectionForm.php:
 Non deprecated function showLogExtract calls deprecated function LogPage::logName in line 609
Problems in mediawiki/core/includes/specials/SpecialMovepage.php:
 Non deprecated function showLogFragment calls deprecated function LogPage::logName in line 632
Problems in mediawiki/core/includes/specials/SpecialRevisiondelete.php:
 Non deprecated function execute calls deprecated function LogPage::logName in line 204
 Non deprecated function execute calls deprecated function LogPage::logName in line 209
Problems in mediawiki/core/includes/specials/SpecialMergeHistory.php:
 Non deprecated function showHistory calls deprecated function LogPage::logName in line 230
Problems in mediawiki/core/includes/specials/SpecialUserrights.php:
 Non deprecated function showLogFragment calls deprecated function LogPage::logName in line 608
Problems in mediawiki/core/includes/specials/SpecialUndelete.php:
 Non deprecated function showHistory calls deprecated function LogPage::logName in line 1074
 Non deprecated function showHistory calls deprecated function LogPage::logName in line 1078
Problems in mediawiki/core/includes/FileDeleteForm.php:
 Non deprecated function showLogEntries calls deprecated function LogPage::logName in line 282
Problems in mediawiki/core/includes/logging/LogPage.php:
 Non deprecated function getTitleLink calls deprecated function LogPage::logName in line 419
Comment 1 Dereckson 2012-06-15 21:58:17 UTC 
Taking this bug.
Comment 2 Dereckson 2012-06-21 12:04:28 UTC 
Patch code:
http://dereckson.devio.us/patches/MediaWiki-20120619-37638-replace-deprecated-LogPage-logName.patch

Before to push it to gerrit, I would like to test if the lognames are still printed correctly.

Code is deployed on http://mediawiki.dereckson.be/

If you create an account there, you could perhaps help me to check that?
Comment 3 Dereckson 2012-06-21 12:56:21 UTC 
Code review: Gerrit change #12362
Comment 4 matanya 2012-08-15 12:45:51 UTC 
fix merged. closing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links