Last modified: 2012-08-15 01:19:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39641, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37641 - Undefined constant NS_MODULE/NS_MODULE_TALK
Undefined constant NS_MODULE/NS_MODULE_TALK
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Scribunto (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-15 23:10 UTC by Sam Reed (reedy)
Modified: 2012-08-15 01:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-06-15 23:10:24 UTC 
This is also going to create some noise in LocalisationUpdate/Scap too...

Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /var/www/wiki/mediawiki/extensions/Scribunto/Scribunto.namespaces.php on line 6

Call Stack:
    0.0018     652200   1. {main}() /var/www/wiki/mediawiki/core/index.php:0
    0.0022     652768   2. require('/var/www/wiki/mediawiki/core/includes/WebStart.php') /var/www/wiki/mediawiki/core/index.php:54
    0.0521    3266960   3. require_once('/var/www/wiki/mediawiki/core/includes/Setup.php') /var/www/wiki/mediawiki/core/includes/WebStart.php:157
    0.0756    4181544   4. Language::factory() /var/www/wiki/mediawiki/core/includes/Setup.php:498
    0.0757    4181544   5. Language::newFromCode() /var/www/wiki/mediawiki/core/languages/Language.php:184
    0.0804    4335424   6. Language::getFallbacksFor() /var/www/wiki/mediawiki/core/languages/Language.php:220
    0.0860    4825840   7. LocalisationCache->getItem() /var/www/wiki/mediawiki/core/languages/Language.php:3810
    0.0860    4825840   8. LocalisationCache->loadItem() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:238
    0.0860    4825840   9. LocalisationCache->initLanguage() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:303
    0.1014    4898408  10. LocalisationCache->recache() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:418
    1.3957    8470488  11. LocalisationCache->readPHPFile() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:653
    1.3966    8474096  12. include('/var/www/wiki/mediawiki/extensions/Scribunto/Scribunto.namespaces.php') /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:476


Notice: Use of undefined constant NS_MODULE_TALK - assumed 'NS_MODULE_TALK' in /var/www/wiki/mediawiki/extensions/Scribunto/Scribunto.namespaces.php on line 7

Call Stack:
    0.0018     652200   1. {main}() /var/www/wiki/mediawiki/core/index.php:0
    0.0022     652768   2. require('/var/www/wiki/mediawiki/core/includes/WebStart.php') /var/www/wiki/mediawiki/core/index.php:54
    0.0521    3266960   3. require_once('/var/www/wiki/mediawiki/core/includes/Setup.php') /var/www/wiki/mediawiki/core/includes/WebStart.php:157
    0.0756    4181544   4. Language::factory() /var/www/wiki/mediawiki/core/includes/Setup.php:498
    0.0757    4181544   5. Language::newFromCode() /var/www/wiki/mediawiki/core/languages/Language.php:184
    0.0804    4335424   6. Language::getFallbacksFor() /var/www/wiki/mediawiki/core/languages/Language.php:220
    0.0860    4825840   7. LocalisationCache->getItem() /var/www/wiki/mediawiki/core/languages/Language.php:3810
    0.0860    4825840   8. LocalisationCache->loadItem() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:238
    0.0860    4825840   9. LocalisationCache->initLanguage() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:303
    0.1014    4898408  10. LocalisationCache->recache() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:418
    1.3957    8470488  11. LocalisationCache->readPHPFile() /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:653
    1.3966    8474096  12. include('/var/www/wiki/mediawiki/extensions/Scribunto/Scribunto.namespaces.php') /var/www/wiki/mediawiki/core/includes/LocalisationCache.php:476
Comment 1 Sam Reed (reedy) 2012-06-15 23:19:52 UTC 
Hmmm.. They went away.

Still, the way it's declared, based on a global, in something called in an $wgExtensionFunctions... then used the namespaces file?
Comment 2 Sam Reed (reedy) 2012-06-21 13:18:15 UTC 
Spews a few notices in update.php too
Comment 3 Tim Starling 2012-07-09 03:30:43 UTC 
Maybe it should just be some large fixed integer. I considered having all the code use $wgScribuntoNamespaceNumbers['Module'] directly, but that would potentially make Scribunto.namespaces.php look pretty ugly.
Comment 4 Sam Reed (reedy) 2012-07-09 14:55:33 UTC 
(In reply to comment #3)
> Maybe it should just be some large fixed integer. I considered having all the
> code use $wgScribuntoNamespaceNumbers['Module'] directly, but that would
> potentially make Scribunto.namespaces.php look pretty ugly.

Seems sensible, and define them as constants. Then to shut up errors on the namespace alias files define them if not defined
Comment 5 Tim Starling 2012-08-15 01:19:38 UTC 
Fixed in I18e53127147f62a8b2058537f7b054c253ba126e
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links