Last modified: 2012-12-21 13:06:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39655, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37655 - gitweb: grep needle is not encoded correctly when echoed back
gitweb: grep needle is not encoded correctly when echoed back
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-16 15:23 UTC by Liangent
Modified: 2012-12-21 13:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2012-06-16 15:23:37 UTC 
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=search;st=grep;s=%E7%BB%B4 see top right corner. The search keyword is decoded as iso-8859-1 then encoded as utf-8 then sent back. Maybe we want to use utf-8 in both steps.
Comment 1 Chad H. 2012-06-16 16:53:51 UTC 
This is an upstream bug in either Gitweb or Gerrit.
Comment 2 Rob Lanphier 2012-06-21 21:35:53 UTC 
Liangent, could you file this with the Gitweb project?
Comment 3 Liangent 2012-06-22 04:06:05 UTC 
(In reply to comment #2)
> Liangent, could you file this with the Gitweb project?

Where is it?
Comment 4 Chad H. 2012-12-20 17:54:10 UTC 
Not going to worry about this since the plan is to ditch gitweb anyway -> WONTFIX.
Comment 5 Liangent 2012-12-21 04:59:20 UTC 
(In reply to comment #4)
> Not going to worry about this since the plan is to ditch gitweb anyway ->
> WONTFIX.

What will be its replacement?
Comment 6 Liangent 2012-12-21 05:00:48 UTC 
(In reply to comment #4)
> Not going to worry about this since the plan is to ditch gitweb anyway ->
> WONTFIX.

However I see this bug fixed now.
Comment 7 Chad H. 2012-12-21 13:06:19 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > Not going to worry about this since the plan is to ditch gitweb anyway ->
> > WONTFIX.
> 
> What will be its replacement?

Gitblit, see bug 38383.

(In reply to comment #6)
> (In reply to comment #4)
> > Not going to worry about this since the plan is to ditch gitweb anyway ->
> > WONTFIX.
> 
> However I see this bug fixed now.

Must've magically fixed itself, nobody actually did anything.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links