Last modified: 2012-11-29 13:03:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39677, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37677 - ApiModifyItem uses mb_strcut and there is no fallback defined
ApiModifyItem uses mb_strcut and there is no fallback defined
Status: VERIFIED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-18 09:30 UTC by jeblad
Modified: 2012-11-29 13:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jeblad 2012-06-18 09:30:01 UTC
Autocomments uses multibyte strings and for trimming those to correct length it uses mb_strcut. This function should be reimplemented in the Fallback file.
Comment 1 Siebrand Mazeland 2012-06-18 09:31:08 UTC
Or the extension can simply require mb_string?
Comment 2 jeblad 2012-06-18 11:20:08 UTC
It is possible to make a fairly fast function as a replacement, but it is easier to simply say the extension require multibye strings to work properly. For now I'm pushing this on the backlog, its more important to support multibyte strings by using the ordinary library than making a fallback. Or is there any important usecase where the missing fallback will be a blocker?
Comment 3 Sam Reed (reedy) 2012-06-19 00:44:19 UTC
Note, trunk has other fallbacks for mb_ functions...
Comment 4 jeblad 2012-07-08 19:21:11 UTC
Seems like it is possible to avoid it, and the problem only exist in a patchset that is not used.

I'm tempted to mark it as fixed, but will let it hang around until I fix the patchset.
Comment 5 jeblad 2012-07-27 11:30:34 UTC
Not used anymore

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links