Last modified: 2012-12-13 11:17:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39681, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37681 - Can't show old revisions of Wikibase Items
Can't show old revisions of Wikibase Items
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Wikidata bugs
storypoints: 2
:
Depends on: 37682
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-18 11:55 UTC by Daniel Kinzler
Modified: 2012-12-13 11:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-06-18 11:55:13 UTC 
The implementation of ItemViewAction doesn't support showing old revision, it always shows the newest.
Comment 1 Daniel Kinzler 2012-06-18 15:02:02 UTC 
Using Article::view to implement ItemView would probably fix this, see bug #37682
Comment 2 Daniel Kinzler 2012-06-26 09:22:10 UTC 
fixed via bug 37682
Comment 3 denny vrandecic 2012-06-26 09:28:36 UTC 
This is very cool, thanks! Is there a way to get a header saying "this is an old version" or something? Open a new item or reopen this bug for that?
Comment 4 Daniel Kinzler 2012-06-26 09:31:48 UTC 
Actually, such a warning should be shown exactly if and when it's shown for wikitext pages... is that not the case?
Comment 5 Daniel Kinzler 2012-06-26 09:32:48 UTC 
Ah, note that the javascript editing stuff may hide or remove some things from the top of the page! Perhaps open a bug report for that, it needs more investigation.

Try to turn off JS and view an old revision.
Comment 6 denny vrandecic 2012-06-26 11:14:02 UTC 
I cannot reproduce your suggestion, i.e. switching of JavaScript does not bring the note back. Then again, right now the viewing an old item seems to be broken anyway -- is that due to the revert in the morning?
Comment 7 Daniel Kinzler 2012-06-26 12:46:26 UTC 
yes, the revert undid support for this. reopening.
Comment 8 denny vrandecic 2012-06-28 10:23:14 UTC 
Need tests once the dependencies are closed.
Comment 9 Anja Jentzsch 2012-11-29 12:38:09 UTC 
Verified in Wikidata demo time for sprint 8
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links