Last modified: 2012-12-13 11:17:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39682, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37682 - ItemViewAction should use Article::view
ItemViewAction should use Article::view
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Daniel Kinzler
storypoints: 8
:
Depends on:
Blocks: 37588 37681
  Show dependency treegraph
 
Reported: 2012-06-18 11:59 UTC by Daniel Kinzler
Modified: 2012-12-13 11:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-06-18 11:59:15 UTC
The ItemViewAction class should use an Article object, possibly with some methods overwritten, to show page content. Action::view implements a *lot* of functionality that is required when showing page content, is not yet supported for Items, and would be pointless and unmaintainable to re-implement. Here are a few things that would need to be addressed:

* permission checks
* showing old revisions and diffs
* messing with the page title for the main page, etc
* using the parser cache when appropriate
* dealing with redirects

...and there's more.

We may need to modify the Article class a bit to make this work for us, e.g. by factoring out some functionality into methods that can easily be overwritten.
Comment 1 Daniel Kinzler 2012-06-25 12:14:57 UTC
under review https://gerrit.wikimedia.org/r/#/c/12857/
Comment 2 Daniel Kinzler 2012-06-26 12:46:35 UTC
reverted, reopening.
Comment 3 Daniel Kinzler 2012-06-26 15:42:28 UTC
Things to check when implementing this:
* do non-existing pages work as expected?
* can blocked users see the page? (see 37961)
* do blocked users see the edit features?
* do users see the edit features if the page is protected?
Comment 4 Anja Jentzsch 2012-11-29 12:38:11 UTC
Verified in Wikidata demo time for sprint 8

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links