Last modified: 2014-01-03 15:51:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39690, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37690 - "In moderation" spam from mediawiki-commits-bounces triggered by Gerrit mail
"In moderation" spam from mediawiki-commits-bounces triggered by Gerrit mail
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Mailing lists (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://translatewiki.net/static/temp/...
: ops
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-18 14:21 UTC by Niklas Laxström
Modified: 2014-01-03 15:51 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-06-18 14:21:36 UTC
Your mail to 'MediaWiki-CVS' with the subject

   [Gerrit] Clean up Ibc6cc01a and fix breakage with old style
configs - change (mediawiki...Translate[master])

Is being held until the list moderator can review it for approval.

The reason it is being held:

   Post to moderated list

Either the message will get posted to the list, or you will receive
notification of the moderator's decision.  If you would like to cancel
this posting, please visit the following URL:
Comment 1 Daniel Zahn 2012-06-18 14:40:56 UTC
please ask Tim since he is the list owner. for now i will just copy configs from old to new list when renaming. and/or request more moderators for the list.
Comment 2 Niklas Laxström 2012-06-18 14:41:48 UTC
I have not posted anything to MediaWiki-CVS myself. This has been going on for few days.
Comment 3 Daniel Zahn 2012-06-18 14:43:52 UTC
It started when Gerrit was recently switched to start sending mail to this list but we did not allow Gerrit as a sender. Meanwhile we have allowed gerrit addresses though..hmm
Comment 4 Niklas Laxström 2012-06-19 09:29:06 UTC
Now the spam is coming from mediawiki-commits :)
Comment 5 Chad H. 2012-06-19 18:05:57 UTC
I'm not getting any such spam myself. E-mails definitely aren't getting through though :\
Comment 6 Niklas Laxström 2012-06-20 09:35:26 UTC
Check spam folder? :) I'm still getting them.
Comment 7 Chad H. 2012-06-21 19:13:42 UTC
(In reply to comment #6)
> Check spam folder? :) I'm still getting them.

Definitely not getting them...could you perhaps pastebin the e-mail (with all the headers) somewhere?
Comment 8 Siebrand Mazeland 2012-06-21 21:08:48 UTC
(In reply to comment #7)

> Definitely not getting them...could you perhaps pastebin the e-mail (with all
> the headers) somewhere?

https://translatewiki.net/static/temp/mail.txt
Comment 9 Rob Lanphier 2012-06-21 21:33:24 UTC
Tim is the list owner for historic reasons, but there's no reason to have him as the bottleneck on this issue.  This is really more about configuring Mailman than it is about Gerrit, so switching the component.
Comment 10 Niklas Laxström 2012-06-27 15:07:20 UTC
Can someone explain what is holding the fix for this bug.
Comment 11 Chad H. 2012-06-27 15:22:31 UTC
(In reply to comment #9)
> Tim is the list owner for historic reasons, but there's no reason to have him
> as the bottleneck on this issue.  This is really more about configuring Mailman
> than it is about Gerrit, so switching the component.

I'm willing to take ownership, if someone can reset the password for me.

(In reply to comment #10)
> Can someone explain what is holding the fix for this bug.

Because I'm not 100% sure what the issue is yet. I thought we whitelisted gerrit for e-mailing, but it's not working. Having list admin access would help.
Comment 12 Thehelpfulone 2012-09-02 14:51:09 UTC
Chad, I see that you are now list admin for the new list: https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits - did you manage to fix this problem?
Comment 13 Siebrand Mazeland 2012-09-02 14:55:58 UTC
(In reply to comment #12)
> Chad, I see that you are now list admin for the new list:
> https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits - did you manage
> to fix this problem?

I "fixed" this with a sub optimal solution. The main problem probably still exists (details known with Chad).
Comment 14 Siebrand Mazeland 2012-09-02 14:58:21 UTC
(private comment)

Temporary solution is to remove moderation for the subscribers that also commit. I've done this when a mail was being held.

Drawback of this is that these people can also post to the list directly if they knew this was the case.
Comment 15 Niklas Laxström 2012-09-22 17:48:54 UTC
I'm not getting these emails any longer. Chad: can we close this bug or do you want to keep it open?
Comment 16 Chad H. 2012-09-22 18:37:37 UTC
Let's leave it open for now. The solution Siebrand has is not ideal for the long term...we need to find a real solution eventually.
Comment 17 Andre Klapper 2013-07-25 17:44:53 UTC
(In reply to comment #15)
> I'm not getting these emails any longer. Chad: can we close this bug or do
> you want to keep it open?

So can anybody judge if this is still a problem?

Updating subject as per comment 4.

I'm tempted to close this as WORKSFORME, plus missing an example email that exposes the mail headers (example in comment 8 is a 404).
Comment 18 Siebrand Mazeland 2013-08-04 17:03:55 UTC
Phew. That took a while to find.

Solution:
- subscribe gerrit@wikimedia.org to the list using the mass subscription feature of the admin interface.
- set no mail delivery for the subscriber using the admin interface

Solution provided by Maarten and implemented already for pywikipedia commits. Thanks!

I've also reverted the changes for the previous work-around and made my earlier comment no longer private.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links