Last modified: 2013-10-09 15:16:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39713, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37713 - MWHttpRequest::execute doesn't return a value
MWHttpRequest::execute doesn't return a value
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-19 14:36 UTC by jeblad
Modified: 2013-10-09 15:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description jeblad 2012-06-19 14:36:00 UTC 
According to documentation execute() should return a value, which it does not.
Comment 1 Sam Reed (reedy) 2012-06-19 16:06:19 UTC 
(In reply to comment #0)
> According to documentation execute() should return a value, which it does not.

Technically, the function in that class isn't documented ;)
Comment 2 Chad H. 2012-06-26 23:32:47 UTC 
We should change the documentation to remove the @return then. No need to make it return anything.
Comment 3 Nischay Nahata 2013-02-06 14:59:54 UTC 
seems like this has been worked upon https://gerrit.wikimedia.org/r/#/c/47712/
Comment 4 Nischay Nahata 2013-02-22 05:31:04 UTC 
I think execute() should be made abstract and its code moved to some other method 'setup'?

or at least make it protected?
Comment 5 Andre Klapper 2013-07-24 10:47:35 UTC 
Patch in Gerrit needs rework...
Comment 6 Gerrit Notification Bot 2013-10-09 15:16:25 UTC 
Change 47712 abandoned by Siebrand:
(bug 37713) Fix documentation for `MWHttpRequest::execute`

Reason:
Abandoning this change. Feel free to revive if there is reason to.

https://gerrit.wikimedia.org/r/47712
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links