Last modified: 2012-10-31 09:07:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39727, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37727 - move geoIP lookup back to the head
move geoIP lookup back to the head
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 26234
  Show dependency tree / graph
 
Reported: 2012-06-19 23:09 UTC by Ryan Kaldari
Modified: 2012-10-31 09:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2012-06-19 23:09:09 UTC 
Now that we can use http://bits.wikimedia.org/geoiplookup, we should move the geoIP lookup back to the head of the page so that the Geo var is available to all scripts immediately.
Comment 1 Peter Gehres 2012-06-19 23:18:01 UTC 
Awesome! This should reduce the "banner bump," yes?
Comment 2 Ryan Kaldari 2012-06-19 23:21:57 UTC 
Yes, although this is only the first step of eliminating the banner bump. Some other changes will be necessary as well.
Comment 3 Ryan Kaldari 2012-06-20 19:28:46 UTC 
Looks like this might be rather difficult as there is no longer any way to add scripts to the head other than through ResourceLoader (which only works for local scripts). Might have to get creative and hack this into core.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links