Last modified: 2013-02-08 15:53:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39755, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37755 - robots noindex,nofollow not set


Summary:	robots noindex,nofollow not set

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Page editing (Other open bugs)
Version:	1.19
Hardware:	All All

Importance:	Unprioritized normal with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Duplicates:	44730 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-06-20 18:55 UTC by schinken
Modified:	2013-02-08 15:53 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Set 'noindex,nofollow' robot meta tag on 'view source' pages (1.53 KB, patch) 2012-10-12 15:43 UTC, Oren Held	Details
Add an attachment (proposed patch, testcase, etc.)

Description schinken 2012-06-20 18:55:16 UTC

If the permissions for editing pages is restricted to guests, the meta-tags for robots are not set (noindex,nofollow)

It happens inside the EditPage-Function, where the Permissions are checked.
If the user is not allowed to edit a page, it returns from that function and never executes the "setHeader" function.

This function is responsible for setting the robots noindex,nofollow metatag

Comment 1 Oren Held 2012-10-12 15:43:15 UTC

Created attachment 11186 [details]
Set 'noindex,nofollow' robot meta tag on 'view source' pages

I believe this patch is important for SEO reasons. I see no good reason to allow crawlers to index 'view source' mode in addition to the regular article view.

Comment 2 Andre Klapper 2012-10-12 15:58:04 UTC

Hi Oren, thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier for us to review it quickly.
Thanks again!  We appreciate your contribution.

Comment 3 Oren Held 2012-10-13 11:00:08 UTC

Thanks! So much better indeed, not sure how come I missed that in the developer docs.

Submitted to Gerrit (https://gerrit.wikimedia.org/r/#/c/27867/).

Comment 4 Alexandre Emsenhuber [IAlex] 2012-12-02 09:02:48 UTC

Change merged.

Comment 5 db [inactive,noenotif] 2013-02-08 15:53:38 UTC

*** Bug 44730 has been marked as a duplicate of this bug. ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links