Last modified: 2012-10-29 18:09:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39808, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37808 - VisualEditor freaks out on <span>
VisualEditor freaks out on <span>
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2012-10-15
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-21 21:28 UTC by Max Semenik
Modified: 2012-10-29 18:09 UTC (History)
6 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2012-06-21 21:28:11 UTC
After I vandalised the test page with[1], trying to edit this page resulted in "renderers[annotation.type] is undefined"

var openAnnotations = function( annotations ) {
    var out = '',
        annotation;
    for ( var hash in annotations ) {
        annotation = annotations[hash];
        out += typeof renderers[annotation.type].open === 'function' ? <-- here
            renderers[annotation.type].open( annotation.data ) :
            renderers[annotation.type].open;
        hashStack.push( hash );
        annotationStack[hash] = annotation;
    }


----
[1] https://www.mediawiki.org/w/index.php?title=VisualEditor:Test&diff=552553&oldid=552537
Comment 1 Roan Kattouw 2012-06-21 21:29:27 UTC
Yeah, this is because span is listed as an annotation but has no renderer defined. Fixing.
Comment 2 Roan Kattouw 2012-06-21 21:50:24 UTC
Fixed in https://gerrit.wikimedia.org/r/12539 , pending review in Gerrit.
Comment 3 James Forrester 2012-10-15 22:57:17 UTC
Mass-moving old VisualEditor tickets to the VE product. Search for this message to mass-delete bugmail.
Comment 4 James Forrester 2012-10-29 18:09:51 UTC
Noting bugs closed in the 2012-10-15 release.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links