Last modified: 2012-08-09 18:25:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39820, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37820 - VisualEditor: Creating link over an existing link is broken
VisualEditor: Creating link over an existing link is broken
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2012-08-06
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-22 05:12 UTC by Liangent
Modified: 2012-08-09 18:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 James Forrester 2012-06-22 22:05:47 UTC
Mass-moving items into VisualEditor product
Comment 2 Rob Moen 2012-07-30 18:20:05 UTC
Fixed and included in August 6th deployment.
Comment 4 Liangent 2012-08-06 17:25:53 UTC
Ouch, did the deployment take place?
Comment 5 James Forrester 2012-08-06 17:42:29 UTC
No. :-) Per http://wikitech.wikimedia.org/view/Software_deployments#Ongoing it is scheduled to happen from 19 minutes' time, for up to three hours. Remarking as resolved.
Comment 6 Liangent 2012-08-07 20:35:37 UTC
(In reply to comment #5)
> No. :-) Per http://wikitech.wikimedia.org/view/Software_deployments#Ongoing it
> is scheduled to happen from 19 minutes' time, for up to three hours. Remarking
> as resolved.

Is it deployed now so I can re-test these bugs?
Comment 7 MZMcBride 2012-08-07 21:41:53 UTC
(In reply to comment #6)
> (In reply to comment #5)
>> No. :-) Per http://wikitech.wikimedia.org/view/Software_deployments#Ongoing it
>> is scheduled to happen from 19 minutes' time, for up to three hours. Remarking
>> as resolved.
> 
> Is it deployed now so I can re-test these bugs?

Hmm, perhaps VisualEditor should have some kind of exposure of a version number or last deployment date? Given the frequent deployments and code changes, I think it'd be helpful for testing and bug-filing. I'm not sure if Special:Version covers this already. Perhaps a separate bug is needed?

Re-opening this bug for now. Until the bug filer can verify that the bug has been fixed, it doesn't make much sense to mark it as such. We don't really use "verified" in our current Bugzilla workflow, though perhaps we ought to in the future.
Comment 8 Liangent 2012-08-07 21:47:24 UTC
(In reply to comment #7)
> Re-opening this bug for now. Until the bug filer can verify that the bug has
> been fixed, it doesn't make much sense to mark it as such. We don't really use
> "verified" in our current Bugzilla workflow, though perhaps we ought to in the
> future.

Some of us are using it, see bug 39040.
Comment 9 James Forrester 2012-08-07 22:02:00 UTC
Max - This bug is already explicitly tagged against a release milestone (this last Monday's), as you'd see if you looked. :-)

Liangent - This is fixed and 'in live' as of yesterday, but unfortunately you won't be able to tell as bug 39111 has broken the link inspector entirely (sorry, we should have tested this before deployment). Will live-patch in the next few hours, at which point I'll ping back on this bug.
Comment 10 MZMcBride 2012-08-08 02:16:13 UTC
(In reply to comment #9)
> Max - This bug is already explicitly tagged against a release milestone (this
> last Monday's), as you'd see if you looked. :-)

James, I saw the bug filer not being able to verify that the bug was fixed. That's more than enough to mark it as reopened. Start meeting your deployment schedule and provide a way to measure which version of VisualEditor is deployed (in addition to, you know, fixing the actual reported bug) and then you can comment about what I did or did not notice.
Comment 11 MZMcBride 2012-08-08 02:32:20 UTC
(In reply to comment #5)
> No. :-) Per http://wikitech.wikimedia.org/view/Software_deployments#Ongoing it
> is scheduled to happen from 19 minutes' time, for up to three hours. Remarking
> as resolved.

I looked at <http://wikitech.wikimedia.org/view/Software_deployments#Ongoing> and its associated page history and I have no idea what this comment is referring to. There's no mention of VisualEditor on that page. The only mention of VisualEditor I can find is at <http://wikitech.wikimedia.org/view/Software_deployments/2012_archive> in an entry dated June 21.
Comment 12 Roan Kattouw 2012-08-08 15:31:14 UTC
(In reply to comment #7)
> Hmm, perhaps VisualEditor should have some kind of exposure of a version number
> or last deployment date? Given the frequent deployments and code changes, I
> think it'd be helpful for testing and bug-filing. I'm not sure if
> Special:Version covers this already. Perhaps a separate bug is needed?
> 
Special:Version lists the git hash of the deployed version, which isn't perfect (and was out of date until just now). There is also a version number there which is currently just set to 0.1, I suppose we could start using that field, either by incrementing it each time or by using something like 0.1-20120806.

Anyway, as for deployment frequency: not counting the fixup deployments that occurred yesterday because various things were broken, there is only one VE deployment every two weeks, on the first Monday of every deployment cycle. The most recent deployment was last Monday (Aug 6), the next one will be on Aug 20, then two weeks after that, etc. This is because our code comes along for the ride with the 1.20wmf* deployments (see https://www.mediawiki.org/wiki/MediaWiki_1.20/Roadmap for the schedule) and the only wiki where VE is currently deployed (mw.org) is part of phase 0, which occurs on the first Monday.

Hope that clears things up a bit.
Comment 13 MZMcBride 2012-08-08 22:03:19 UTC
(In reply to comment #12)
> (In reply to comment #7)
> > Hmm, perhaps VisualEditor should have some kind of exposure of a version number
> > or last deployment date? Given the frequent deployments and code changes, I
> > think it'd be helpful for testing and bug-filing. I'm not sure if
> > Special:Version covers this already. Perhaps a separate bug is needed?
> > 
> Special:Version lists the git hash of the deployed version, which isn't perfect
> (and was out of date until just now). There is also a version number there
> which is currently just set to 0.1, I suppose we could start using that field,
> either by incrementing it each time or by using something like 0.1-20120806.

It'd certainly be nice for debugging, yes. I was thinking about some kind of user preference or URL parameter or something that would add an HTML comment with useful debug info in it. I can imagine a few data points being helpful, but particularly VisualEditor version number, so people don't end up chasing down bugs that were fixed a week ago.

> Anyway, as for deployment frequency: not counting the fixup deployments that
> occurred yesterday because various things were broken, there is only one VE
> deployment every two weeks, on the first Monday of every deployment cycle. The
> most recent deployment was last Monday (Aug 6), the next one will be on Aug 20,
> then two weeks after that, etc. This is because our code comes along for the
> ride with the 1.20wmf* deployments (see
> https://www.mediawiki.org/wiki/MediaWiki_1.20/Roadmap for the schedule) and the
> only wiki where VE is currently deployed (mw.org) is part of phase 0, which
> occurs on the first Monday.
> 
> Hope that clears things up a bit.

Yes, thank you, that was very helpful. I've no idea how the hell anyone is supposed to know that (beyond reading your comment here on this bug). It'd be nice if http://wikitech.wikimedia.org/view/Software_deployments and https://www.mediawiki.org/wiki/MediaWiki_1.20/Roadmap noted this. Is this only for VisualEditor or are all Wikimedia extensions updated every two weeks now?
Comment 14 Roan Kattouw 2012-08-09 18:25:45 UTC
(In reply to comment #13)
> Yes, thank you, that was very helpful. I've no idea how the hell anyone is
> supposed to know that (beyond reading your comment here on this bug).
Yeah, I apologize for the poor discoverability of this information :(

> It'd be
> nice if http://wikitech.wikimedia.org/view/Software_deployments and
> https://www.mediawiki.org/wiki/MediaWiki_1.20/Roadmap noted this. Is this only
> for VisualEditor or are all Wikimedia extensions updated every two weeks now?
All WMF extensions are updated from master every two weeks, same as core. Some WMF-maintained extensions have additional deployment windows scheduled to accelerate deployments, but everything is on the two-weekly deployment train. If people want their deployments to be slower, we tell them to keep their code out of master until it's ready.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links