Last modified: 2012-09-23 09:12:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39966, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37966 - 'patrolmarks' should be included in the rights registry
'patrolmarks' should be included in the rights registry
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: 1.20.0 release
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 14:49 UTC by MA
Modified: 2012-09-23 09:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MA 2012-06-26 14:49:37 UTC
Please make that the 'patrolmarks' permission be avalaible as a global
permission. Actually there's no checkbox for it at Special:GlobalGroupPermissions.

Example of missing checkbox:

<https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions/sysadmin>

Note: I see this is kind of an implicit group to sysops unless you change the config at InitialiseSettings.php for the project ie: eswiki: ('*' => array( 'patrolmarks' => true ),)

Thank you.
Comment 1 Alex Monk 2012-06-26 18:41:35 UTC
That's odd, I thought all groups were supposed to show on that page...
Comment 2 Krinkle 2012-06-26 19:00:10 UTC
Nobody has the 'patrolmarks' right by default in MediaWiki. The right 'patrol' implies 'patrolmarks'. They can't be separated because it doesn't make sense to be able to patrol without seeing what you can and can't patrol.

There is one usage of 'patrolmarks' in MediaWiki: User::useRCPatrol/useNPPatrol.

Since nobody has it, MediaWiki doesn't know about it. 

The following is commented out in DefaultSettings.php:

//$wgGroupPermissions['*']['patrolmarks']      = false; // let anons see what was patrolled


So it is not even explicitly set to 'false' for anyone either.

Moving to MediaWiki core since this is a bug in MediaWIki. It should be included in the coreRights registry and be explicitly set to false or true for at least one user group.
Comment 3 Krinkle 2012-09-20 21:24:19 UTC
Only 2 lines of code need to change (User.php and DefaultSettings):

(In reply to comment #2)
> included in the coreRights registry and be explicitly set to false or true for
> at least one user group.


Will take this next week if nobody else does. Easy one for a new developer as well.
Comment 4 Alexandre Emsenhuber [IAlex] 2012-09-23 09:12:07 UTC
Fixed in Gerrit change #19203.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links