Last modified: 2012-07-03 16:11:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39979, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37979 - Deploy and enable WikipediaShopLink for testwiki
Deploy and enable WikipediaShopLink for testwiki
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-27 01:49 UTC by James Alexander
Modified: 2012-07-03 16:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Alexander 2012-06-27 01:49:51 UTC
If we could get WikimediaShopLink deployed and enabled that would be great. I believe I committed most of the changes needed to turn it on for testwiki. I would eventually want to enable it for enwiki but that would be a couple days after.

https://gerrit.wikimedia.org/r/#/c/11012/ - extension review commit

https://gerrit.wikimedia.org/r/#/c/13098/ - add as submodule to 1.20wmf5
https://gerrit.wikimedia.org/r/#/c/13101/ - add as submodule to 1.20wmf6
https://gerrit.wikimedia.org/r/#/c/13099/ - config settings, testwiki only
https://gerrit.wikimedia.org/r/13105 - add to make-wmf-branch
Comment 1 Sam Reed (reedy) 2012-06-27 01:55:43 UTC
If it's only going on testwiki now, it only needs to be in 1.20wmf6

Though, you need to add it to extension-list, see 13099
Comment 2 Sam Reed (reedy) 2012-06-27 01:57:15 UTC
Minor:

	'messages'      => array(
		'wikimediashoplink-desc',
		'wikimediashoplink',
		'wikimediashoplink-linktext',
	)

You're only using 'wikimediashoplink-linktext' in JS, any reason to export the others?
Comment 3 James Alexander 2012-06-27 02:26:32 UTC
Thanks reedy, I adjusted the messages (they were from an old version) in https://gerrit.wikimedia.org/r/#/c/13106/ and added the extension-list piece
Comment 4 Sam Reed (reedy) 2012-06-27 11:57:46 UTC
Not accepted it into 1.20wmf5 yet (no point). Needs a scap run, but is otherwise live on test/test2

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links