Last modified: 2013-08-03 22:51:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39997, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37997 - [performance] Interval not cleared: 2 Intervals per file
[performance] Interval not cleared: 2 Intervals per file
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-27 19:39 UTC by Rainer Rillke @commons.wikimedia
Modified: 2013-08-03 22:51 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot showing Firebug, UploadWizard and Mozilla Firefox. CSS has been tweaked to make the input visible. (54.79 KB, image/png)
2013-08-03 01:52 UTC, Rainer Rillke @commons.wikimedia
Details

Description Rainer Rillke @commons.wikimedia 2012-06-27 19:39:32 UTC
Simply test it: During the whole upload process 2 intervalls *per file* are not cleared:

var se = window.setInterval;
window.setInterval = function (fn, t) {

return se(function() {
console.log(fn, t);
fn();
}, t)
};

If you upload 50 files, this means 100 events fire (all the time) within 500ms, executing a function that is computing some numbers from the DOM (object position) and setting CSS. Not good for old machines and slow browsers.

Culprit:
/extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js

moveFileInputToCover: function( selector ) {
//...

this.moveFileInputInterval = window.setInterval(function() {
update();
}, 500); 
}
Comment 1 Gerrit Notification Bot 2013-07-22 15:53:34 UTC
Change 75122 had a related patch set uploaded by Rillke:
Improved file-control positioning

https://gerrit.wikimedia.org/r/75122
Comment 2 Gerrit Notification Bot 2013-07-22 17:13:47 UTC
Change 75122 abandoned by Rillke:
Improved file-control positioning

Reason:
Too much work to do. No time fixing boring white-space.

https://gerrit.wikimedia.org/r/75122
Comment 3 Gerrit Notification Bot 2013-07-22 18:46:40 UTC
Change 75122 restored by Alex Monk:
Improved file-control positioning

Reason:
Don't abandon changes for such silly reasons.

https://gerrit.wikimedia.org/r/75122
Comment 4 Rainer Rillke @commons.wikimedia 2013-08-03 01:52:56 UTC
Created attachment 13056 [details]
Screenshot showing Firebug, UploadWizard and Mozilla Firefox. CSS has been tweaked to make the input visible.
Comment 5 Gerrit Notification Bot 2013-08-03 22:51:31 UTC
Change 75122 merged by jenkins-bot:
Improved file-control positioning

https://gerrit.wikimedia.org/r/75122

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links