Last modified: 2012-07-06 23:30:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40008, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 38008 - VisualEditor: Tooltips for formatting menu are broken


Summary:	VisualEditor: Tooltips for formatting menu are broken

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized trivial
Target Milestone:	---
Assigned To:	Rob Moen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-06-27 21:54 UTC by James Forrester
Modified:	2012-07-06 23:30 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2012-06-27 21:54:36 UTC

From user feedback. They seem to be unescaped, too - "&lt;visualeditor-formatdropdown-tooltip&gt;" etc.

Comment 1 Brion Vibber 2012-06-28 17:27:27 UTC

I don't see this in Firefox 13/Linux either in the deployment on mediawiki.org or locally. Any details on when/where this happens?

Comment 2 James Forrester 2012-06-28 23:32:38 UTC

Occurs in Chrome/Mac and Safari/Mac, but not Firefox/Mac.

Resultant HTML:

<div class="es-tool es-toolbarDropdownTool es-toolbarDropdownTool-format" title="&lt;visualeditor-formatdropdown-tooltip&gt;">

&lt;visualeditor-formatdropdown-tooltip&gt;

(individual entries don't have tooltips assigned)

Presumably this is meant to use [[MediaWiki:Visualeditor-formatdropdown-tooltip]] which is unititialised on MW.org - but setting it to something doesn't fix the problem:

http://www.mediawiki.org/wiki/MediaWiki:Visualeditor-formatdropdown-tooltip

From perusing the code I think it's in the messages array but missing from the i18n file, and not called by modules/ve/ui/tools/ve.ui.FormatDropdownTool.js, but it's got beyond my patience when rooting around with nano. :-)

Comment 3 Rob Moen 2012-07-06 23:30:08 UTC

Thank you James.
Fixed in https://gerrit.wikimedia.org/r/14599

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links