Last modified: 2012-06-28 13:13:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40024, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38024 - ResourceLoader should not create empty stylesheets for modules that don't have stylesheets
ResourceLoader should not create empty stylesheets for modules that don't hav...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: 1.20.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-28 12:44 UTC by Krinkle
Modified: 2012-06-28 13:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-06-28 12:44:48 UTC
As the title says. With stuff like bug 31676, we definitely don't want to insert more junk then we have to.

For example:

https://www.mediawiki.org/w/load.php?modules=mediawiki.legacy.wikibits

> mw.loader.implement('mediawiki.legacy.wikibits',function(){ .. },{"":""},{});

that third argument there should be an empty object.
Comment 1 Krinkle 2012-06-28 13:13:16 UTC
Change-Id: I436a6a1c64452fc60a58fd9a478a2ac2b1328211

* Saves number of <style> tags inserted, which in turn is good for
  IE's stupid stylesheet limit (bug 31676).

* Also saves a little bit of bandwidth by outputting
  {} instead of {"":""}.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links