Last modified: 2012-07-19 23:56:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40055, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38055 - New Pages Feed: Hide 'Review' button for non-editors
New Pages Feed: Hide 'Review' button for non-editors
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 38151
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-29 01:06 UTC by Fabrice Florin
Modified: 2012-07-19 23:56 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fabrice Florin 2012-06-29 01:06:54 UTC
Don't show the blue 'Review' button on the New Pages Feed list if you are not an editor. 

It's not relevant, and unfairly raises their expectations, since they cannot review that page with the curation bar anyway.
Comment 1 Alex Monk 2012-06-30 15:44:45 UTC
Gerrit change #13629
Comment 2 Ryan Kaldari 2012-06-30 21:06:21 UTC
To clarify a bit: The 'Review' button should only be shown to users with the patrol right, but we do want to show the 'Review' button on all articles in the queue regardless of whether they have already been reviewed or not.
Comment 3 Brandon Harris 2012-07-07 19:37:38 UTC
I'd prefer it if the review button were *disabled* rather than hidden, with a hover stating why it's disabled.

I generally don't like interfaces that add and remove affordances.  Grey it out, fine, but don't remove it entirely.
Comment 4 Fabrice Florin 2012-07-08 23:03:43 UTC
Thanks, Brandon. Your proposal works for me. If you haven't already, can you send a grayed-out version of the button to Kaldari, in case he doesn't have it?
Comment 5 bsitu 2012-07-17 23:30:37 UTC
A new patch is submitted in here: https://gerrit.wikimedia.org/r/#/c/15854/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links