Last modified: 2012-07-19 15:05:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40097, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 38097 - SpecialProofreadPages Fatal error


Summary:	SpecialProofreadPages Fatal error

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ProofreadPage (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Tpt

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-01 01:46 UTC by Sam Reed (reedy)
Modified:	2012-07-19 15:05 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-07-01 01:46:13 UTC

PHP Fatal error:  Call to a member function next() on a non-object in /usr/local/apache/common-local/php-1.20wmf6/extensions/ProofreadPage/SpecialProofreadPages
.php on line 47

Happening during some search outages over the weekend (quite a lot)

$textMatches = $searchEngine->searchText( $this->searchTerm );


$textMatches is then null, so we can't call ->next() on it in a while loop


Should fail gracefully, and in the process, not set suppressSqlOffset to true

Comment 1 Tpt 2012-07-10 14:21:23 UTC

Here is a patch : https://gerrit.wikimedia.org/r/#/c/6808/

Comment 2 Tpt 2012-07-19 15:05:20 UTC

This patch has been merged and solve this bug : https://gerrit.wikimedia.org/r/#/c/14885/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links