Last modified: 2012-07-01 17:18:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40099, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38099 - in Gerrit make tab size 4 instead of 8
in Gerrit make tab size 4 instead of 8
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-01 08:07 UTC by Amir E. Aharoni
Modified: 2012-07-01 17:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2012-07-01 08:07:05 UTC
I fully understand that this may be a bikeshed, but I'll try anyway.

The diff view in Gerrit shows indentation tabs of 8 spaces. When showing two compared revisions of the file, it makes the display very wide. On small screens this very often requires horizontal scrolling.

I am not making any assumptions about the most common tab size among Wikimedia developers. I'm just thinking of being practical and helping people with smaller screen to do code review more efficiently.

If it's possible, it would be helpful to define the Gerrit tab size for 4 spaces.
Comment 1 Niklas Laxström 2012-07-01 08:11:11 UTC
+1 for this request. I even use only size of 2 myself.
Comment 2 Chad H. 2012-07-01 12:04:22 UTC
There's no way to configure this currently, please report upstream.
Comment 3 Amir E. Aharoni 2012-07-01 12:09:33 UTC
I should have looked for it better: it can be changed in the diff preferences and it sticks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links