Last modified: 2012-07-23 20:33:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40119, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38119 - WLM app doesn't scale images properly
WLM app doesn't scale images properly
Status: RESOLVED FIXED
Product: WikiLoves Monuments Mobile
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-02 18:07 UTC by Yuvi Panda
Modified: 2012-07-23 20:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuvi Panda 2012-07-02 18:07:53 UTC
Needs to set size and properly figure out which assets to show for which DPI.
Comment 1 Brion Vibber 2012-07-02 19:37:26 UTC
Something like this should fix:
* set width/height attributes of the 1x images on the <img>
* when checking window.devicePixelRatio, for safety bucket them into:
  - <= 1 -> 1
  - > 1 && < 2 -> 1.5
  - >= 2 -> 2

This'll avoid breaking on ldpi devices where it'll be 0.75, and doesn't need to worry about converting numbers to strings strictly.

Alternately, just use the 2x assets always like we do on the Wikipedia app. ;)
Comment 2 Yuvi Panda 2012-07-08 18:03:32 UTC
Taking the easy way out :) https://github.com/wikimedia/WLMMobile/pull/33 fixes this.
Comment 3 Jon 2012-07-23 20:33:53 UTC
Seems to be addressed from comments above

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links