Last modified: 2013-03-07 19:11:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40135, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38135 - LdapAuthentication: Call to a member function isLoggedIn() on a non-object
LdapAuthentication: Call to a member function isLoggedIn() on a non-object
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LdapAuthentication (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Ryan Lane
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-03 02:23 UTC by Solitarius
Modified: 2013-03-07 19:11 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Solitarius 2012-07-03 02:23:20 UTC
On mediawiki/core (REL1_19) and extension/LdapAuthentication (master), I get the following error:

Fatal error: Call to a member function isLoggedIn() on a non-object in /.../extensions/LdapAuthentication/LdapAuthentication.php on line 1033 

Reverting commit 16f4070c7c340be2621deddc5c3387d68990d019 make it work fine again.
Comment 1 Sam Reed (reedy) 2012-07-03 18:49:39 UTC
(In reply to comment #0)
> On mediawiki/core (REL1_19) and extension/LdapAuthentication (master), I get
> the following error:
> 
> Fatal error: Call to a member function isLoggedIn() on a non-object in
> /.../extensions/LdapAuthentication/LdapAuthentication.php on line 1033 
> 
> Reverting commit 16f4070c7c340be2621deddc5c3387d68990d019 make it work fine
> again.

I'm not sure if master plugin with non master MW is expected to work
Comment 2 Ryan Lane 2012-07-03 19:20:13 UTC
It is. I try to ensure backwards compatibility.
Comment 3 Solitarius 2012-07-03 19:25:05 UTC
It's not a big problem for me now because I was able to find which commit the error came from but it might cause a surprise on the next 'official' release for user of automatic ldap authentication.

The only symptom I still get not is a failure to log on the first page when returning to the site (probably due to session/cookies timeout), reloading or navigation to any other page fix it (session/cookies renewed or something alike).
Comment 4 Solitarius 2013-03-07 16:02:07 UTC
Very crude workaround uploade to gerrit.

https://gerrit.wikimedia.org/r/52622
Comment 5 Ryan Lane 2013-03-07 19:11:17 UTC
Merged in. This change is actually fine. When using auto-authentication, there's no need to pull anything from the database, and wgUser won't be set.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links