Last modified: 2013-06-27 15:27:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40144, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 38144 - "Expand 10 before" and "Expand 10 after" broken on some pages


Summary:	"Expand 10 before" and "Expand 10 after" broken on some pages

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Git/Gerrit (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://code.google.com/p/gerrit/issue...
Whiteboard:
Keywords:	upstream

Duplicates:	45309 48648 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-03 13:48 UTC by Siebrand Mazeland
Modified:	2013-06-27 15:27 UTC (History)
CC List:	10 users (show)

See Also:	http://code.google.com/p/gerrit/issues/detail?id=1233 45309
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2012-07-03 13:48:27 UTC

Clicking "Expand 10 after" on https://gerrit.wikimedia.org/r/#/c/14040/1/wmf-config/InitialiseSettings.php doesn't work.

Firebug:

uncaught exception: Class$LXb: One or more exceptions caught, see full set in UmbrellaException#getCauses
https://gerrit.wikimedia.org/r/gerrit/F603A082B141A26D031D8A8E3846A902.cache.html
Line 1767

Comment 1 Chad H. 2012-07-03 13:49:54 UTC

This is an upstream bug, already filed.

Comment 2 Nemo 2012-11-03 10:59:22 UTC

Verified on Firefox and Chromium.

Comment 3 Andre Klapper 2012-11-04 21:29:05 UTC

Nemo_bis: Verified as in "Verified fixed", or verified as in "issue exists"? :)

Comment 4 Nemo 2012-11-04 21:57:13 UTC

(In reply to comment #3)
> Nemo_bis: Verified as in "Verified fixed", or verified as in "issue exists"? :)

The latter. As the upstream bug says, it's definitely gerrit's fault because big files are not loaded at all, so except the diff nothing else can be shown.

Comment 5 Chad H. 2012-11-19 16:08:41 UTC

This should help: https://gerrit-review.googlesource.com/#/c/30262/

Comment 6 Sumana Harihareswara 2012-12-14 14:41:08 UTC

Chad, I see that the patch upstream is running into review questions/critique; can you check on that at all and tell us how likely it is to be fixed by Gerrit 2.6?

Comment 7 Andre Klapper 2013-02-19 22:49:00 UTC

Still an issue.

Comment 8 Chad H. 2013-02-22 16:00:05 UTC

This is broken for me on all diffs now, grrr :\

Comment 9 Nemo 2013-02-23 12:55:25 UTC

(In reply to comment #8)
> This is broken for me on all diffs now, grrr :\

Split to bug 45309 (I think).

Comment 10 Chad H. 2013-02-23 12:58:11 UTC

This is the same bug, don't see the point in splitting.

Comment 11 Nemo 2013-02-23 13:10:49 UTC

*** Bug 45309 has been marked as a duplicate of this bug. ***

Comment 12 Nemo 2013-02-23 13:11:17 UTC

(In reply to comment #10)
> This is the same bug, don't see the point in splitting.

Ok:

(In reply to comment #11)
> *** Bug 45309 has been marked as a duplicate of this bug. ***

Comment 13 Chad H. 2013-04-12 16:35:03 UTC

Is this broken for anyone but me anymore?

Fwiw, this has remained broken for me in Chrome on OSX (for the past couple of versions, at least). I've been unable to replicate using any other browser on OSX, or when using Chrom(e|ium) on other platforms.

Comment 14 Nemo 2013-04-12 16:38:30 UTC

(In reply to comment #13)
> Is this broken for anyone but me anymore?

Yes.

Comment 15 Niklas Laxström 2013-04-12 21:13:14 UTC

Broken for me with Chrome on Linux for since the last(?) Gerrit upgrade. Somewhat annoying.

Comment 16 Jesús Martínez Novo (Ciencia Al Poder) 2013-05-20 17:21:36 UTC

*** Bug 48648 has been marked as a duplicate of this bug. ***

Comment 17 Chad H. 2013-06-27 15:27:36 UTC

Finally fixed with 2.7-rc2-505-g7502a46.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links