Last modified: 2012-07-30 09:57:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40149, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38149 - RC patrol exclamation marks are reversed
RC patrol exclamation marks are reversed
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CleanChanges (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Niklas Laxström
https://translatewiki.net/w/i.php?tit...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-03 17:45 UTC by Nemo
Modified: 2012-07-30 09:57 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Example (242.79 KB, image/png)
2012-07-03 17:45 UTC, Nemo
Details

Description Nemo 2012-07-03 17:45:21 UTC
Created attachment 10819 [details]
Example

In the example URL, where both clean changes and RC patrol are enabled, the filtering works, but the ! signs are broken: no exclamation mark is shown for unverified diffs (it's still shown for unverified pages). If you don't filter, all verified (eg autopatrolled) changes _and_ pages have the !.
It works correctly with clean changes disabled: https://translatewiki.net/w/i.php?title=Special:RecentChanges&translations=filter&newrc=1&hidepatrolled=1 , https://translatewiki.net/w/i.php?title=Special:RecentChanges&translations=filter&newrc=1 (or if you disable enhanced RC altogether).
Comment 1 Nemo 2012-07-29 08:47:50 UTC
It's also removing the rcid parameter from the new pages with multiple edits in the same day (in enhanced RC, the link with the rcid is the first timestamp for the page), which makes it impossible to patrol them.
I've verified that it works on Meta, so it must be CleanChanges.
Comment 2 Niklas Laxström 2012-07-29 17:53:58 UTC
https://gerrit.wikimedia.org/r/16919
Comment 3 Nemo 2012-07-30 09:08:58 UTC
"Patch has been merged. Please test once it has been deployed and mark as verified."
I will test when TWN is updated.
Comment 4 Nemo 2012-07-30 09:45:05 UTC
Still no rcid link as in comment 1, comment 0 fixed.
Comment 5 Nemo 2012-07-30 09:57:31 UTC
(In reply to comment #1)
> It's also removing the rcid parameter from the new pages with multiple edits in
> the same day (in enhanced RC, the link with the rcid is the first timestamp for
> the page), which makes it impossible to patrol them.
> I've verified that it works on Meta, so it must be CleanChanges.

Filed as bug 38834.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links