Last modified: 2012-07-03 21:45:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40152, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38152 - jquery.tablesorter should use .data() instead of .attr() for retrieving the (custom) sort-value
jquery.tablesorter should use .data() instead of .attr() for retrieving the (...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: 1.20.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-03 20:13 UTC by Krinkle
Modified: 2012-07-03 21:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2012-07-03 20:13:27 UTC 
The data-sort-value attribute is used to pre-populate the data storage, but later modifications are only stored in the properties, not in the attributes.

Calling .data() will do the same as .attr(), except that .data() will be up to date if the value has changed.

Discovered when implementing bug 24950.
Comment 1 Niklas Laxström 2012-07-03 20:17:37 UTC 
That was done when .data() didn't yet exists.
Comment 2 Krinkle 2012-07-03 20:23:08 UTC 
Maybe, the unit tests written at the time use data() though.

Im fixing this now + unit test.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links