Last modified: 2012-09-04 16:07:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40154, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 38154 - VisualEditor: Build out support for Monobook


Summary:	VisualEditor: Build out support for Monobook

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High enhancement
Target Milestone:	VE-deploy-2012-09-03
Assigned To:	Trevor Parscal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-03 21:23 UTC by MZMcBride
Modified:	2012-09-04 16:07 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2012-07-03 21:23:29 UTC

The VisualEditor extension currently only works with the Vector skin. It should work with other skins such as Monobook.

From [mediawiki/extensions/VisualEditor.git] / VisualEditor.hooks.php (<https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/VisualEditor.git;a=blob;f=VisualEditor.hooks.php;h=e43fef59dd678ba5309f2335829dd6fe1e041a2d;hb=4fea35acd451c939a522ab7a4d7bd13e4ac95e76>):

---
class VisualEditorHooks {
	/**
	 * Adds VisualEditor JS to the output if in the correct namespace.
	 *
	 * This is attached to the MediaWiki 'BeforePageDisplay' hook.
	 *
	 * @param $output OutputPage
	 * @param $skin Skin
	 */
	public static function onBeforePageDisplay( &$output, &$skin ) {
		global $wgTitle;
		if (
			// Vector skin supported for now.
			$skin->getSkinName() === 'vector' &&
			(
				// Article in the VisualEditor namespace
				$wgTitle->getNamespace() === NS_VISUALEDITOR ||
				// Special page action for an article in the VisualEditor namespace
				$skin->getRelevantTitle()->getNamespace() === NS_VISUALEDITOR
			)
		) {
			$output->addModules( array( 'ext.visualEditor.editPageInit' ) );
		}
		return true;
	}
---

Comment 1 MZMcBride 2012-07-03 21:24:23 UTC

Bumping the importance of this as it's annoying the shit out of me when trying to play with the extension.

Comment 2 James Forrester 2012-07-03 21:30:16 UTC

Enhancement, not bug. Resource issues are non-trivial. To discuss as part of the product strategy.

Comment 3 MZMcBride 2012-07-03 21:42:57 UTC

(In reply to comment #2)
> Enhancement, not bug. Resource issues are non-trivial. To discuss as part of
> the product strategy.

I've found the cost of all the noise switching back and forth between bug and enhancement to far outweigh any benefit. I don't care what you call this ticket and neither does nearly any other ticket filer.

The VisualEditor extension should work with non-Vector skins. (And the fact that it doesn't is getting in the way of power-users, a good number of whom use Monobook.)

You can classify the request as whatever you'd like or just disable the stupid categorization altogether. Nobody cares.

Comment 4 Trevor Parscal 2012-08-23 18:04:25 UTC

I've added support for Monobook in Ia39e034229204ae5f1f70dce5d74c6c4db42277b

This doesn't mean "all" skins are supported, so I am not sure I should close the bug, but for most purposes this is sufficient.

Comment 5 Trevor Parscal 2012-08-23 18:05:34 UTC

The primary request here was monobook support - I've renamed the bug and am now closing it.

Comment 6 MZMcBride 2012-08-24 01:27:15 UTC

(In reply to comment #4)
> I've added support for Monobook in Ia39e034229204ae5f1f70dce5d74c6c4db42277b

Awesome. Thank you, Trevor!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links