Last modified: 2012-09-21 20:04:59 UTC
For some reason the leading on "Today's Featured Article" is screwed up. It looks fine on any regular articles, but looks bad on the home page.
Weird, it looks fine now. I wonder if it had something to do with that Featured Article not having an image. That's the only difference I can think of.
Can't replicate so closing to keep bug noise level down.
Reopening since I saw the same problem when the Main Page featured an imageless article again recently.
INext time it happens could you take a closer look at what's going on and try to articulate why this is happening? It's obviously specific to certain articles as it only happens every now and again. Otherwise this bug is likely to stay open for 4 years with no activity. I'm keen to get to the point where __all bugs__ in bugzilla for mobile projects are actionable. e.g. they provide a path to replicate the issue, they explain what is wrong with it ("screwed up" is not very precise :-)) and what the expected behaviour is. I believe when we get to this point we provide a better route for newbies into mediawiki development. Sorry if I sound like an arse but I firmly believe this is the way forward ! You say the problem occurred due to the featuring of an imageless article - was this the case for the original bug report? How is it screwed up - can you provide a screenshot? Is this a margin issue, is the text unreadable? I suspect this is an issue with the template being used for the main page rather than an issue with mobilefrontend - it would be good to get to the bottom of this.
Found the problem. The line-height only gets applied if the text is inside a <p> or in a div with id 'featured_article': p, li, dl, #featured_article { line-height: 1.65; } However, the featured article div isn't IDed as 'featured_article'. Instead it's IDed with the rather mysterious 'mp-tfa', which gets no styling.
The reason it works if there is a picture is that this triggers the text being put in a <p> tag.
Oh, I guess 'mp-tfa' must be Main Page - Today's Featured Article :)
I guess the best solution would just be to add '#mp-tfa' to the existing list in the CSS. So: p, li, dl, #mp-tfa, #featured_article { line-height: 1.65; } Not sure what file this is in, but it's gotta be one of the CSS files included in the MobileFrontend modules.
Anything with the mp- prefix gets added to the main page - everything else gets scrubbed. This is also wikipedia specific so should not be put in mobile frontend core. So where does the issue lie? * Can we add a generic css rule in mobile frontend? * Should wikitext be changed to make sure these go in a p * Is there something we can do in the template to ensure this get dealt with e.g. add an already supported class add an id #featured_article ?
https://gerrit.wikimedia.org/r/24582
