Last modified: 2014-04-07 16:53:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40218, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38218 - Custom toolbar buttons location changes
Custom toolbar buttons location changes
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.19.0
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-06 16:53 UTC by ineuw
Modified: 2014-04-07 16:53 UTC (History)
8 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Image of the changed toolbar buttons position (12.96 KB, image/jpeg)
2012-07-06 16:53 UTC, ineuw
Details
Source pages of both conditions copied from View Source page of Firefox (199.93 KB, text/plain)
2012-07-06 17:01 UTC, ineuw
Details

Description ineuw 2012-07-06 16:53:26 UTC
Created attachment 10825 [details]
Image of the changed toolbar buttons position

After the upgrade to mw1.19, the custom toolbar keeps switching positions from appearing correctly at the end of the regular toolbar to splitting the regular edit toolbar into two parts. Also the revised code for custom toolbar buttons doesn't work for me.

This happens on Wikimedia Commons and Wikipedia and most importantly on Wikisource, where most of my editing is done.

Recently, the positional change became more frequent, and I copied the source page code of both conditions, and created a .jpg image of both as they appear in Wikisource.
Comment 1 ineuw 2012-07-06 17:01:15 UTC
Created attachment 10826 [details]
Source pages of both conditions copied from View Source page of Firefox

Additional file containing the Source pages of both conditions - with the correct toolbar position code on top, followed by the incorrect toolbar position code.
Comment 2 ineuw 2012-08-21 13:17:40 UTC
The preamble: The wikisource editor environment is made up of two toolbar button sets.

The attached images display the first step of Wikimedia modifications to the "wikisource toolbar button layout" in wmf version 1.18f9. In this version the additional custom edit buttons added by users, which were always located at the end of the toolbar, have been inserted between the "wikisource specific" and the "wikimedia standard toolbar" buttons sets. 

The 2nd step of the wikisource editor toolbar layout changes is reported in Bug 39367.
Comment 3 Andre Klapper 2013-05-16 15:14:57 UTC
Hi ineuw! Sorry that nobody has taken a look at this report yet and given feedback.

Which browser(s) and version does this happen with?
Can this be seen on a public Wikimedia wiki, or is this a private wiki? If private, which MediaWiki version do you run currently, and does this still happen?
Comment 4 Derk-Jan Hartman 2014-04-07 16:28:11 UTC
This is not part of the WikiEditor extension, but of core
Comment 5 ineuw 2014-04-07 16:48:39 UTC
Please consider this bug report as closed as well.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links