Last modified: 2013-03-19 20:38:12 UTC
Created attachment 10827 [details] Patch to allow search by filter ID for all filters (with abusefilter-log-private right) Hello, In Special:AbuseLog, users with the "abusefilter-log-private" right have access to all the details of entries corresponding to private filters (i.e. they will see "triggered filter X" instead of "triggered an abuse filter" and can view the diff). However, they cannot filter entries by entering the filter ID of a private filter. For instance, assume that you have the "abusefilter-log-private" right but not "abusefilter-private" and that filter #2 is private. If you enter "2" in "Filter ID" of the form at the top of Special:AbuseLog, you will see the log of all filters instead of the log of filter #2. For consistency, "abusefilter-log-private" should allow you to view only the log of filter #2 (why would users be allowed to view the diff of entries that they can't find?). This can be fixed by a one-line change in SpecialAbuseLog.php. I have attached a possible patch, that I tested on a private wiki (this is the first time I try to do that, so tell me if there is anything wrong...).
Hi! Thanks for your patch and sorry for the late answer! You are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial Putting your branch in Git makes it easier for us to review it quickly. Thanks again! We appreciate your contribution.
Hi Andre, I don't plan to submit patches anymore, and unfortunately I will not be able to do anything more for this one, sorry.
In fact this bug was solved a long time ago in Gerrit change #14008.
