Last modified: 2014-05-05 18:40:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40239, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38239 - Establish suitable short-term replacement for important code review tags
Establish suitable short-term replacement for important code review tags
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 38671
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-08 03:27 UTC by Rob Lanphier
Modified: 2014-05-05 18:40 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Lanphier 2012-07-08 03:27:15 UTC
Right now this document has a section titled "Annotations":
https://www.mediawiki.org/wiki/Git/Code_review/guide#Annotations

We have several tags ("scaptrap", "schema", "fixme", and the tags used for marking things for backporting, for example) that don't have equivalent workflow replacements in the brave new world of Git and Gerrit.  At a minimum, we need to update the guide, but more importantly, we need to have replacement workflows that don't involve hoping the Gerrit devs get around to implementing tags.

(permalink to annotations: https://www.mediawiki.org/w/index.php?title=Git/Code_review/guide&oldid=559641#Annotations )
Comment 1 Greg Grossmeier 2013-04-19 21:33:15 UTC
Chad: Any update on this work? I would love to start using this to track backports for wmf deploys (and I'm sure Mark H would love it for managing some of his release work as well).

Anything blocking you here other than time?
Comment 2 Rob Lanphier 2013-09-04 20:53:46 UTC
It's going to be a while before Gerrit supports the features that we need to make this work.  Let's come up with a non-technical workaround for this problem.  Greg, can you work with the team on some sort of process for this?
Comment 3 Greg Grossmeier 2013-10-28 18:15:41 UTC
Update on this:

Some things I've been doing:
1) communicating more frequently with the features teams to get an idea of risk/other needed dependencies for their deploys.

2) A partial solution is the "Next WMF Deploy" tracking bug (bug 38865). But that is only useful for things that have an associated bug (and it needs the person to be able to read the bug for context, which can be noisy).

3) still wishing we had tags in Gerrit.... https://code.google.com/p/gerrit/issues/detail?id=287

With tags in Gerrit, we could have git-deploy/Sartoris/Trebuchet display such information to the deployer (with confirmation that they looked at them) when such scaptrap/highrisk changes are getting ready to be deployed.

Unassigning from self for now, will add to DevOps backlog (due to the use-case with git-deploy).
Comment 4 Andre Klapper 2014-03-13 13:57:35 UTC
(In reply to Greg Grossmeier from comment #3)
> Unassigning from self for now, will add to DevOps backlog (due to the
> use-case with git-deploy).

Still high priority on the list?
Comment 5 Greg Grossmeier 2014-03-13 17:41:13 UTC
This should just be a requirement for the next thing we switch to (since the momentum behind getting it in gerrit is mostly gone).

Fabricator almost has this with their "tokens" thing.

Flagging seems user specific.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links