Last modified: 2012-08-28 16:08:16 UTC
When using an existing photo, we end up with a content:// URI which we can reasonably suspect is persistent. When taking a new photo, we end up with a file:// URI into our app's cache space; this seems potentially dangerous. If we save for later, there's a possibility that our cache space might get cleared out at some point (?). When saving for later we should probably save to more permanent storage. [Check whether auto cache-clearing actually happens; if not then we can maybe ignore this and hope for the best.]
I just checked and found the pictures in /mnt/sdcard/DCIM/Camera. This is on a Nexus S. Perhaps this changes with phone?
On my Galaxy Nexus: D/FileTransfer(25939): upload file:///mnt/sdcard/Android/data/org.wikipedia.wlm/cache/1345503933589.jpg to https://test.wikipedia.org/w/api.php No sign of it in /mnt/sdcard/DCIM/Camera, but I see pictures in /mnt/sdcard/Android/data/org.wikipedia.wlm/cache/ indeed.
I did a quick test with adding saveToPhotoAlbum: true to the camera options. This gives us back a content:// URL which sounds nice, but... I don't see the photos in the Gallery app, which is a bit worrying.
How serious is this issue? Will saved for later images get lost if the phone restarts/app gets killed/ ... ? I have also noticed that if I take a photo using the app, it does not appear in my gallery so I cannot reuse it later.
I would say this is serious. It is totally counter to user expectations if photos do not get saved to the gallery. And it will really piss people off if a photo is lost altogether, because uploads may not make it to Commons. None of the photos I've taken with the app have made it to my gallery. Nexus One, Android 2.3.6
ill run some more tesyd wirh rhe saveToGsllery mode tonight if you guys dont get to it first.
Upstream issue with saveToPhotoAlbum option on Android: https://issues.apache.org/jira/browse/CB-924 Apparently even when saving to the album, images don't always show up in the Gallery app until you reboot the phone (or unmount/remount SD card, if an SD card exists). According to the bug this is fixed in 1.9.0, but I can confirm with both our customized 2.0.0 and a stock 2.0.0 that it's still failing in this way on my Galaxy Nexus running 4.0.4.
Pull req to save things to photo gallery, however per the above the photos may not be visible at least on some devices until a reboot (!) https://github.com/wikimedia/WLMMobile/pull/194
