Last modified: 2012-09-05 01:54:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40317, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38317 - WLMMobile: 'cancel' during upload doesn't actually cancel the upload
WLMMobile: 'cancel' during upload doesn't actually cancel the upload
Status: RESOLVED FIXED
Product: WikiLoves Monuments Mobile
Classification: Unclassified
Upload (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Brion Vibber
: upstream
Depends on:
Blocks: 37577
  Show dependency tree / graph
 
Reported: 2012-07-11 17:06 UTC by Brion Vibber
Modified: 2012-09-05 01:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2012-07-11 17:06:55 UTC 
Hitting 'cancel' during upload cancels out of the UI, but the actual upload request is still going.

Currently FileTransfer.upload() has no way to actually abort an upload, so we may need to hack this into Cordova.
Comment 1 Brion Vibber 2012-07-11 17:08:11 UTC 
Upstream bug: https://issues.apache.org/jira/browse/CB-836
Comment 2 Brion Vibber 2012-07-24 23:40:42 UTC 
https://github.com/wikimedia/WLMMobile/pull/72 for initial implementation
Comment 3 Jon 2012-08-28 20:28:51 UTC 
When it says "Launching photo into internet..." hitting cancel doesn't actually cancel the upload :( This is causing bug  39690
Comment 4 Jon 2012-08-28 20:58:45 UTC 
I guess we could disable the cancel button when it reaches this state?
Comment 5 Brion Vibber 2012-08-28 21:06:05 UTC 
we should be able to abort the xhr for the second api rewuest... i think
Comment 6 Jon 2012-08-28 21:16:17 UTC 
*** Bug 39690 has been marked as a duplicate of this bug. ***
Comment 7 Arthur Richards 2012-08-28 22:31:09 UTC 
This is not actually a duplicate of 39690. The problem with hitting 'cancel' while the status reads 'launcing to the internet' still exists and is completely independent of 39690.
Comment 8 Arthur Richards 2012-08-31 18:24:04 UTC 
We should just disable the cancel button when the image is being 'launched into the internet'
Comment 10 Brion Vibber 2012-09-05 01:54:09 UTC 
Merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links