Last modified: 2013-02-19 23:12:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40335, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38335 - Source code highlighting confused in diff view
Source code highlighting confused in diff view
Status: REOPENED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://gerrit.wikimedia.org/r/#/c/15...
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-11 17:53 UTC by Niklas Laxström
Modified: 2013-02-19 23:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Example from URL (92.28 KB, image/png)
2013-02-19 23:12 UTC, Nemo
Details

Description Niklas Laxström 2012-07-11 17:53:44 UTC
See the above url. It is all greek to me.
Comment 1 Alex Monk 2012-07-11 17:56:27 UTC
Looks fine to me.
Comment 2 Niklas Laxström 2012-07-11 18:12:57 UTC
It starts about in the middle of the file and syntax coloring must be enabled.
Comment 3 Alex Monk 2012-07-11 18:14:53 UTC
Ah, I see it now.
Comment 4 Alex Monk 2012-07-11 18:27:30 UTC
I guess this is caused by the heredoc being hidden as common lines.
Comment 5 Niklas Laxström 2012-07-11 19:49:17 UTC
It's not about being hidden. It's just getting confused at the heredoc.
Comment 6 Chad H. 2012-07-24 18:28:44 UTC
I filed this bug upstream almost 3 weeks ago. Resolving LATER until something happens there.
Comment 7 Chad H. 2012-07-24 18:30:57 UTC
Seems to be upstream of Gerrit as well, see http://code.google.com/p/google-code-prettify/issues/detail?id=41
Comment 8 Nemo 2012-11-14 12:33:27 UTC
Switching from LATER to the second most relevant resolution for fear of information loss. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/65116
Comment 9 Nemo 2012-11-14 12:39:15 UTC
Both upstream and up-upstream bugs are still open; I can't actually see the bug myself but it's probably me.
Comment 10 Andre Klapper 2013-02-19 22:52:30 UTC
Cannot spot anything strange in https://gerrit.wikimedia.org/r/#/c/15451/1/Babel.class.php either.
<<<  (heredoc) is used in lines 95 and 233 but nothing weird visible.

Nikkerabit: Do you remember what the problem was? (Screenshots welcome.)
Comment 11 Nemo 2013-02-19 23:12:15 UTC
Created attachment 11809 [details]
Example from URL

As I said it was just me. :) Seen on Firefox and Chrome, as explained on https://code.google.com/p/support/issues/detail?id=3763 : after $box = <<<EOT (and actually even starting a bit before it), everything is treated as a single string so all colours get lost; compare for instance the lines selected in the screenshot.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links