Last modified: 2013-11-11 18:50:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40345, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38345 - Moodbar smileys styled by JS-added class instead of plain CSS
Moodbar smileys styled by JS-added class instead of plain CSS
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
MoodBar (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nischay Nahata
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-11 21:11 UTC by Yair Rand
Modified: 2013-11-11 18:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yair Rand 2012-07-11 21:11:56 UTC 
There's some very strange code in ext.moodBar.core.js where the JS applies the CSS class 'mw-moodBar-types-hover' when the user hovers over the element, and then removes the class when the mouse is moved away. This style is then used to apply the correct background image (the darkened faces) to the happy/sad/confused faces.  The individual faces are, however, styled to the colored faces by simply using the :hover pseudo-class, so clearly using :hover isn't considered to be problematic. None of the elements are links, so IE6 is apparently being ignored for these styles. 

Is there any reason not to just remove the class-applying JS code (lines 239-243 in moodBar.core.js) and replace the uses of 'mw-moodBar-types-hover' with 'mw-moodBar-types:hover' in moodBar.core.css?
Comment 1 Nischay Nahata 2013-02-17 12:20:18 UTC 
https://gerrit.wikimedia.org/r/#/c/49478/
Comment 2 Gerrit Notification Bot 2013-11-11 18:50:27 UTC 
Change 49478 had a related patch set uploaded by Krinkle:
(bug 38345) use :hover instead of jQuery based styling.

https://gerrit.wikimedia.org/r/49478
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links