Last modified: 2012-07-26 19:48:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40348, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 38348 - Pinch to zoom is not working on some devices


Summary:	Pinch to zoom is not working on some devices

Status:	RESOLVED FIXED

Product:	WikiLoves Monuments Mobile
Classification:	Unclassified
Component:	Maps (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	37577
	Show dependency tree / graph

Reported:	2012-07-11 21:35 UTC by Tomasz Finc
Modified:	2012-07-26 19:48 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	Android
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tomasz Finc 2012-07-11 21:35:23 UTC

lets make it as robust as the wikipedia app

Comment 1 Brion Vibber 2012-07-12 18:08:04 UTC

For parity with Wikipedia app:
* drop the 'PinchZoom' Cordova extension
* when setting up the map, don't enable touchZoom or disable zoomControls if we are on Android 2

That'll leave us with double-tap to zoom in and the +/- zoom in/out buttons on Android 2.x, and more reliable pinch-to-zoom on Android 3/4 (and potentially iPhone if we end up making an iOS build later).

Comment 2 Jon 2012-07-23 22:30:12 UTC

It's not working on my android 4.0.2

This seems to be a leaflet bug... I just tried the latest master (non-stable) of leaflet and the problem went away. It's discussed on https://github.com/CloudMade/Leaflet/issues/150

Should we upgrade?

Comment 3 matanya 2012-07-24 06:38:39 UTC

marking as anodroid related.

Comment 4 Jon 2012-07-24 23:23:28 UTC

I decided not to upgrade and instead just disable pinch zoom

https://github.com/wikimedia/WLMMobile/pull/71

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links