Last modified: 2012-07-18 00:02:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40454, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38454 - 2 PHP notices after last merges...
2 PHP notices after last merges...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-17 20:39 UTC by Sam Reed (reedy)
Modified: 2012-07-18 00:02 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-07-17 20:39:59 UTC 
Notice: Undefined variable: imageTitle in /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php on line 152

Call Stack:
    0.0001     641432   1. {main}() /var/www/wiki/mediawiki/core/index.php:0
    0.1391    5854192   2. MediaWiki->run() /var/www/wiki/mediawiki/core/index.php:58
    0.1392    5854192   3. MediaWiki->main() /var/www/wiki/mediawiki/core/includes/Wiki.php:511
    1.6021   30575952   4. MediaWiki->finalCleanup() /var/www/wiki/mediawiki/core/includes/Wiki.php:602
    1.6025   30576032   5. OutputPage->output() /var/www/wiki/mediawiki/core/includes/Wiki.php:405
    1.6043   30666480   6. wfRunHooks() /var/www/wiki/mediawiki/core/includes/OutputPage.php:1994
    1.6043   30666480   7. Hooks::run() /var/www/wiki/mediawiki/core/includes/GlobalFunctions.php:3967
    1.6200   30852496   8. call_user_func_array() /var/www/wiki/mediawiki/core/includes/Hooks.php:216
    1.6200   30853112   9. ProofreadPage::onBeforePageDisplay() /var/www/wiki/mediawiki/core/includes/Hooks.php:0
    1.6207   30853888  10. ProofreadPage::preparePage() /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php:350
    1.6208   30853888  11. ProofreadPage::load_index() /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php:388


Notice: Undefined offset: 1 in /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php on line 391

Call Stack:
    0.0001     641432   1. {main}() /var/www/wiki/mediawiki/core/index.php:0
    0.1391    5854192   2. MediaWiki->run() /var/www/wiki/mediawiki/core/index.php:58
    0.1392    5854192   3. MediaWiki->main() /var/www/wiki/mediawiki/core/includes/Wiki.php:511
    1.6021   30575952   4. MediaWiki->finalCleanup() /var/www/wiki/mediawiki/core/includes/Wiki.php:602
    1.6025   30576032   5. OutputPage->output() /var/www/wiki/mediawiki/core/includes/Wiki.php:405
    1.6043   30666480   6. wfRunHooks() /var/www/wiki/mediawiki/core/includes/OutputPage.php:1994
    1.6043   30666480   7. Hooks::run() /var/www/wiki/mediawiki/core/includes/GlobalFunctions.php:3967
    1.6200   30852496   8. call_user_func_array() /var/www/wiki/mediawiki/core/includes/Hooks.php:216
    1.6200   30853112   9. ProofreadPage::onBeforePageDisplay() /var/www/wiki/mediawiki/core/includes/Hooks.php:0
    1.6207   30853888  10. ProofreadPage::preparePage() /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php:350
Comment 1 Sam Reed (reedy) 2012-07-17 20:50:54 UTC 
First one fixed in https://gerrit.wikimedia.org/r/15837
Comment 2 Sam Reed (reedy) 2012-07-17 20:58:25 UTC 
https://gerrit.wikimedia.org/r/#/c/15838/
Comment 3 Sam Reed (reedy) 2012-07-17 23:52:47 UTC 
(In reply to comment #2)
> https://gerrit.wikimedia.org/r/#/c/15838/

Doesn't fully fix the problem.. I guess although this is correct, and preg_match needs to return true, it still doesn't mean there's enough captured items..



Notice: Undefined offset: 1 in /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php on line 392

Call Stack:
    0.0009     652136   1. {main}() /var/www/wiki/mediawiki/core/index.php:0
    0.2639   19209848   2. MediaWiki->run() /var/www/wiki/mediawiki/core/index.php:58
    0.2640   19209848   3. MediaWiki->main() /var/www/wiki/mediawiki/core/includes/Wiki.php:511
    1.1539   46826216   4. MediaWiki->finalCleanup() /var/www/wiki/mediawiki/core/includes/Wiki.php:602
    1.1541   46826296   5. OutputPage->output() /var/www/wiki/mediawiki/core/includes/Wiki.php:405
    1.1559   46916744   6. wfRunHooks() /var/www/wiki/mediawiki/core/includes/OutputPage.php:1994
    1.1559   46916744   7. Hooks::run() /var/www/wiki/mediawiki/core/includes/GlobalFunctions.php:3967
    1.1660   47102744   8. call_user_func_array() /var/www/wiki/mediawiki/core/includes/Hooks.php:216
    1.1660   47103360   9. ProofreadPage::onBeforePageDisplay() /var/www/wiki/mediawiki/core/includes/Hooks.php:0
    1.1665   47104136  10. ProofreadPage::preparePage() /var/www/wiki/mediawiki/extensions/ProofreadPage/ProofreadPage_body.php:351
Comment 4 Sam Reed (reedy) 2012-07-17 23:57:51 UTC 
Cause is https://gerrit.wikimedia.org/r/11725
Comment 5 Sam Reed (reedy) 2012-07-18 00:01:13 UTC 
I suspect this usage of regex is also not needed
Comment 6 Sam Reed (reedy) 2012-07-18 00:02:53 UTC 
Bah, looks like it might've been cached. I hate computers.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links