Last modified: 2014-09-22 22:34:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40514, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38514 - Parsoid: Support PST pipe trick
Parsoid: Support PST pipe trick
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
token-stream transforms (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Mark Holmquist
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-20 02:17 UTC by Roan Kattouw
Modified: 2014-09-22 22:34 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2012-07-20 02:17:14 UTC
Parsing [[Foo (bar)|]] should result in a link to "Foo (bar)" with caption "Foo", but currently isn't parsed at all (it just comes back raw). The same goes for [[San Francisco, California|]] and [[w:Foo|]].
Comment 1 James Forrester 2012-08-06 19:25:45 UTC
Mass-moving bugs into the new 'Parsoid' product.
Comment 2 Mark Holmquist 2012-08-06 22:38:26 UTC
https://gerrit.wikimedia.org/r/17896

Bam.
Comment 3 Gabriel Wicke 2012-08-06 22:57:30 UTC
Merged and verified as fixed.
Comment 4 Mark Holmquist 2012-08-08 15:52:48 UTC
OK, I've just looked this page up:

http://en.wikipedia.org/wiki/Help:Pipe_trick#Reverse_pipe_trick

Apparently there's some kind of crazy magic that happens when you use the reverse pipe trick, depending on where the link is.

There are also some other rules on that page that I didn't necessarily follow, for example, only removing *either* the comma *or* the parenthesis, but never both.

Could someone verify that the above page is accurate, so we can be sure about the accuracy of my addition?

Also, is it helpful for us to consider the reverse pipe trick? That basically means that we would need to always have a page title in consideration, rather than simply parsing the language. Then again, maybe we already do this and there's nothing to worry about.
Comment 5 ssastry 2014-09-22 22:32:14 UTC
Jackmcbarn pointed on IRC that Parsoid shouldn't be supporting pipe trick on the parse pipeline. It is only meant to be be a transformation that the parsing front-end doesn't understand.

Verified with https://en.wikipedia.org/w/api.php?action=parse&text=﷒0﷓]] that it renders as plain text. Just recording this here after the fact, so when someone looks up this ticket on bugzilla, this updated info. is available. Will rip out this support (or add a new ticket for doing so).
Comment 6 ssastry 2014-09-22 22:34:30 UTC
(In reply to ssastry from comment #5)
> Jackmcbarn pointed on IRC that Parsoid shouldn't be supporting pipe trick on
> the parse pipeline. It is only meant to be be a transformation that the
> parsing front-end doesn't understand.
> 
> Verified with https://en.wikipedia.org/w/api.php?action=parse&text=﷒0﷓]]

Ugh .. so, the link got garbled when it went through BZ ... but, try passing "Hampi (temple)|" in the wikilink syntax to the parse api.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links