Last modified: 2012-07-25 20:11:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40645, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38645 - WLM app shows duplicate listings when browsing through Map View
WLM app shows duplicate listings when browsing through Map View
Status: RESOLVED FIXED
Product: Wiki Loves Monuments
Classification: Unclassified
Sources (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Maarten Dammers
:
Depends on:
Blocks: 37577
  Show dependency treegraph
 
Reported: 2012-07-24 17:50 UTC by Tomasz Finc
Modified: 2012-07-25 20:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2012-07-24 17:50:08 UTC
I see numerous points that on the map show "2" but zoomed in only show "1". Switching to list view confirms that their are duplicates.
Comment 1 Maarten Dammers 2012-07-24 19:15:09 UTC
Do you have examples where this happened? This might be caused by having listings in multiple languages. See https://commons.wikimedia.org/wiki/Commons:Monuments_database/Statistics to see what countries have multiple languages.
Comment 2 Jon 2012-07-25 00:08:56 UTC
The api seems to be sending duplicates:

Look at the result of this for example:

http://toolserver.org/~erfgoed/api/api.php?format=json&action=search&bbox=-122.42446303367615,37.75649954571735,-122.42253184318542,37.75870070450265

There are 2 with
name="[[Liberty Street Historic District (San Francisco, California)|Liberty Street Historic District]]"

and 2 with
name="[[John McMullen House|John McMullen House]]"
Comment 3 Max Semenik 2012-07-25 09:07:17 UTC
These monuments are listed as both country=us and country=us-ca, something wrong with erfgoedbot.
Comment 4 Maarten Dammers 2012-07-25 20:07:28 UTC
Ah, found my mistake. It was supposed to take the data from https://en.wikipedia.org/wiki/Special:WhatLinksHere/Template:CHL_row and put it in the monuments_us-ca_(en) table. That goes right, but it looks like I forgot a -ca in the import so the wrong table is being imported. Fixed in r1=769&r2=774">https://fisheye.toolserver.org/browse/erfgoed/erfgoedbot/sql/fill_table_monuments_all.sql?r1=769&r2=774

I issued "mysql> delete from monuments_all WHERE country='us-ca';", that might take some time to complete
Comment 5 Maarten Dammers 2012-07-25 20:11:46 UTC
mysql> delete from monuments_all WHERE country='us-ca';
Query OK, 86926 rows affected (6 min 26.15 sec)

http://toolserver.org/~erfgoed/api/api.php?format=json&action=search&bbox=-122.42446303367615,37.75649954571735,-122.42253184318542,37.75870070450265 looks ok now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links