Last modified: 2012-08-03 00:07:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40657, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38657 - VisualEditor: User should be able to select text in the save dialog.
VisualEditor: User should be able to select text in the save dialog.
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2012-08-06
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 00:07 UTC by Krinkle
Modified: 2012-08-03 00:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-07-25 00:07:10 UTC
The user-select: none; style from the ve-toolbar is cascading down into the save dialog, causing issues.

Steps to reproduce:
* View https://www.mediawiki.org/wiki/VisualEditor:Test
* Change some text
* Press "Save page"

Unexpected result:
Users can't select/highlight any text inside the Save page dialog. In Chrome users can at least still select text inside the input field, though in Firefox it applies to form elements as well.

If possible, the easiest fix would be to override user-select inside this save dialog and undo the "none" value. But its possible that that isn't possible (just like like display: block; doesn't do anything if an ancestor is display: none;).

Otherwise it may have the be re-arranged to not be inside an element with class ve-toolbar.
Comment 1 Rob Moen 2012-07-26 18:57:53 UTC
There are issues in Firefox with overriding user-select properties.  Fix involves attaching the save dialog to the toolbar wrapper rather the toolbar itself.

Patch in https://gerrit.wikimedia.org/r/16760

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links