Last modified: 2012-08-27 09:32:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40659, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38659 - comment wrong in jquery.clickTracking.js
comment wrong in jquery.clickTracking.js
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ClickTracking (Other open bugs)
master
All All
: Unprioritized trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-25 02:45 UTC by spage
Modified: 2012-08-27 09:32 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2012-07-25 02:45:13 UTC
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ClickTracking.git;f=modules/jquery.clickTracking.js;hb=HEAD#l12 says
        // Attach a timestamp to the tracked event and append it to the
        // logged event array (mw.tracked).

But there's no mw.tracked key! Just:
        // Attach a timestamp to the action's data (some tracked event)
        // and remember it for $.getTrackedActions()

(I have a local branch fixing this with a few other comment improvements.)
Comment 1 Krinkle 2012-07-31 18:33:12 UTC
It should mention the local "actions" array variable instead.
Comment 2 Ori Livneh 2012-08-27 09:32:25 UTC
Fixed in Gerrit change #21555.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links