Last modified: 2012-08-27 14:58:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40689, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38689 - change 15612 to memcached log has issues
change 15612 to memcached log has issues
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-25 20:17 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-08-27 14:58 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-07-25 20:17:11 UTC 
The change https://gerrit.wikimedia.org/r/#/c/15612/ was meant to enhance our memcached debug output.

It generates loots of warnings like this:  "socket_getpeername(): supplied resource is not a valid Socket resource in /usr/local/apache/common-local/php-1.20wmf8/includes/objectcache/MemcachedClient.php"


Was reverted with https://gerrit.wikimedia.org/r/#/c/16658/ .

This bug is to remember about investigating change 15612 and enhance it.
Comment 1 Antoine "hashar" Musso (WMF) 2012-07-25 20:20:05 UTC 
I have resent the original patch as https://gerrit.wikimedia.org/r/#/c/16668/
Comment 2 Antoine "hashar" Musso (WMF) 2012-08-01 14:37:08 UTC 
The root cause was trying to get socket metadata of a file pointer which is what the lib uses internally (fsockopen returns a file pointer not a socket resource).

Patchset 2 uses  stream_socket_get_name() instead.

Resetting score to 0 :)
Comment 3 Antoine "hashar" Musso (WMF) 2012-08-27 14:58:33 UTC 
Patch merged in.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links