Last modified: 2012-08-01 15:22:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40768, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38768 - Increase gerrit query limit
Increase gerrit query limit
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://lists.wikimedia.org/pipermail/...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-27 20:44 UTC by Nemo
Modified: 2012-08-01 15:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2012-07-27 20:44:53 UTC
The current gerrit query limit is set to 500. This is quite low for us and makes people waste a lot of time, see for instance the stats Sumana needed which required a lot of headaches to start with and 3 queries or a script in the end.
Queries are restricted to people with SSH keys so they shouldn't be a problem.

https://gerrit-review.googlesource.com/#/c/23053/ has been merged a while ago: "This limit applies not only to the `gerrit query` command, but also to the web UI results pagination size."

Maybe we could set it at 5000 as with our nice MediaWiki queries? Or even more? No idea. Those are even open to everyone. ;-)
Comment 1 jeremyb 2012-07-27 21:58:34 UTC
Maybe All-Projects is hidden in prod? or does it not exist? (google results indicate not existing is a Bad Thing)

http://gerrit-dev.wmflabs.org/r/gitweb?p=All-Projects.git;a=summary does exist
https://gerrit.wikimedia.org/r/gitweb?p=All-Projects.git;a=summary is 404

See also https://gerrit.wikimedia.org/r/Documentation/access-control.html
Comment 2 Chad H. 2012-07-27 22:00:50 UTC
(In reply to comment #1)
> Maybe All-Projects is hidden in prod? or does it not exist? (google results
> indicate not existing is a Bad Thing)
> 
> http://gerrit-dev.wmflabs.org/r/gitweb?p=All-Projects.git;a=summary does exist
> https://gerrit.wikimedia.org/r/gitweb?p=All-Projects.git;a=summary is 404
> 
> See also https://gerrit.wikimedia.org/r/Documentation/access-control.html

It exists, it's just not readable by default (all top-level projects implement this). That way we can have private repositories. Although, we probably could just grant Read by default and explicitly DENY reading of the private repos. Either way, it's unrelated to this discussion.
Comment 3 Chad H. 2012-07-27 22:08:55 UTC
As far as increasing the query limit, that's probably a safe thing to do especially now that we're on the newer beefier hardware.

However, I don't want to do it on a Friday when people are going home and won't be watching things. How about we raise it Monday :)
Comment 4 Chad H. 2012-07-31 21:40:45 UTC
db1048 can handle the load easily, so we've gone ahead and raised the query limit to 5000 for logged in users.
Comment 5 Chad H. 2012-08-01 15:22:17 UTC
Quick note: I had to also set anonymous users back to 500. Apparently overriding the original query limits set it to 0 for anons. 500 was their default, so I restored that.

So current settings in All-Projects are:
0,5000 - Registered Users
0,500 - Anonymous Users

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links