Last modified: 2012-09-13 05:48:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40827, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38827 - WikiEditor: Select "thumbnail" as default format for images
WikiEditor: Select "thumbnail" as default format for images
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-30 08:12 UTC by Michael M.
Modified: 2012-09-13 05:48 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2012-07-30 08:12:51 UTC
Since for a normal image one always should use thumb to scale it, I suggest to preselected "thumb" in the format dropdown and to append it in non-dialog mode. If you need some statistics: 59 % of all images in the German Wikipedia (not counting images on discussion and user pages) use "thumb" or an equivalent parameter (that's a fact) and among the other images there are many where "thumb" is just missing because the editor didn't know of it (that's my opinion).
Comment 1 Eran Roz 2012-08-19 19:12:13 UTC
See patch: Gerrit change #20654
Comment 2 kipod 2012-08-21 12:42:31 UTC
(sorry for joining late). IMO, it will be best if the defaults can be set per-project, overriding those hardcoded in the code itself.

as to implementation: Personally, i would prefer setting the defaults through variables in common.js, rather than LocalSettings.php, so sysops can change it when community decides (this would also allow, possibly, for users to set different defaults for themselves, though it is not clear how valuable this is).

peace.
Comment 3 Liron Dorfman 2012-08-25 19:38:37 UTC
Please make the change Kipod wrote about usable as soon as possible.
Comment 4 Eran Roz 2012-08-26 17:04:23 UTC
kipod, thumb is used almost always, in most languages and most projects so I don't see any real need for supporting configuration for changing it other than thumb. 

Supporting such configurations aren't common in JS, and isn't needed as you may always hack the toolbar with something like:
$('textarea').bind('wikiEditor-dialogs-loaded-insert-file',function(e){
	//setting default for insert dialog (get by id the needed element and set it's properties)
});
In such a way you can always set default for any field.
Comment 5 kipod 2012-08-31 15:08:27 UTC
(In reply to comment #4)
> kipod, thumb is used almost always, in most languages and most projects so I
> don't see any real need for supporting configuration for changing it other than
> thumb. 
> 
> Supporting such configurations aren't common in JS, and isn't needed as you may
> always hack the toolbar with something like:
> $('textarea').bind('wikiEditor-dialogs-loaded-insert-file',function(e){
>     //setting default for insert dialog (get by id the needed element and set
> it's properties)
> });
> In such a way you can always set default for any field.

Thanks for the override code snippet.
My comment was meant not just for the "thumb" selection, but for all defaults. e.g., some wikis may want to define specific size as default, while others may not (Same goes for alignment). 
Also, please remember that as part of media wiki code, this goes not just to wikimedia-foundation wikis, but to any other wiki using the media wiki code.

peace.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links